Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fixes #20402

Merged
merged 3 commits into from
Feb 14, 2023
Merged

test: fixes #20402

merged 3 commits into from
Feb 14, 2023

Conversation

viceice
Copy link
Member

@viceice viceice commented Feb 14, 2023

Changes

fix tests

Context

  • jest.resetAllMocks() now resets spy's, so don't reset if nor required
  • if a spy has no mock implementation, it calls the original

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@viceice viceice marked this pull request as ready for review February 14, 2023 13:56
@rarkins rarkins merged commit 42eab15 into renovate/jest-monorepo Feb 14, 2023
@rarkins rarkins deleted the test/fixes branch February 14, 2023 14:46
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants