refactor: delete cached configFilename

[RahulGautamSingh]

Changes

• delete cached config filename if it doesn't exist

Context

• feat(onboarding): use cache to check if repo is onboarded #20733
• In the linked PR I have introduced functionality that detects whether repo is onboarded/not using cache. But we do this detection before using API to search for config-file in repo, thus this part of the code won't be executed. And in the case where repo is not onboarded and onboarding cache is valid we skip the part where we delete the cached configFilename
  

  renovate/lib/workers/repository/onboarding/branch/check.ts

  Lines 64 to 89 in c41cfdb

  	const cache = getCache();
  	if (cache.configFileName) {
  	logger.debug('Checking cached config file name');
  	try {
  	const configFileContent = await platform.getJsonFile(
  	cache.configFileName
  	);
  	if (configFileContent) {
  	if (
  	cache.configFileName !== 'package.json' ||
  	configFileContent.renovate
  	) {
  	logger.debug('Existing config file confirmed');
  	logger.debug(
  	{ fileName: cache.configFileName, config: configFileContent },
  	'Repository config'
  	);
  	return true;
  	}
  	}
  	} catch (err) {
  	// probably file doesn't exist
  	}
  	logger.debug('Existing config file no longer exists');
  	delete cache.configFileName;
  	}

This causes error in the function below when we try to detectRepoFileConfig as we look for a config-file using api but won't find it.
This causes unknown error or file not found error when running on a real repo. So I am adding a try catch to handle the error better.

renovate/lib/workers/repository/init/merge.ts

Lines 50 to 70 in e3c92d2

	export async function detectRepoFileConfig(): Promise<RepoFileConfig> {
	const cache = getCache();
	let { configFileName } = cache;
	if (configFileName) {
	const configFileRaw = await platform.getRawFile(configFileName);
	if (configFileRaw) {
	let configFileParsed = JSON5.parse(configFileRaw);
	if (configFileName !== 'package.json') {
	return { configFileName, configFileRaw, configFileParsed };
	}
	configFileParsed = configFileParsed.renovate;
	return { configFileName, configFileParsed }; // don't return raw 'package.json'
	} else {
	logger.debug('Existing config file no longer exists');
	}
	}
	configFileName = (await detectConfigFile()) ?? undefined;
	if (!configFileName) {
	logger.debug('No renovate config file found');
	return {};
	}

Documentation (please check one with an [x])

• I have updated the documentation, or
• No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

• Code inspection only, or
• Newly added/modified unit tests, or
• No unit tests but ran on a real repository, or
• Both unit tests + ran on a real repository

[viceice]

needs coverage

[renovate-release]

🎉 This PR is included in version 34.158.2 🎉

The release is available on:

• GitHub release
• 34.158.2

Your semantic-release bot 📦🚀