Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: exactOptionalPropertyTypes #20761

Merged
merged 7 commits into from
Mar 19, 2023
Merged

refactor: exactOptionalPropertyTypes #20761

merged 7 commits into from
Mar 19, 2023

Conversation

RahulGautamSingh
Copy link
Collaborator

Changes

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@RahulGautamSingh RahulGautamSingh marked this pull request as ready for review March 9, 2023 13:43
@rarkins rarkins requested a review from JamieMagee March 11, 2023 05:25
JamieMagee
JamieMagee previously approved these changes Mar 12, 2023
View reviewed changes
Copy link
Contributor

@JamieMagee JamieMagee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there more changes required, or can you enable exactOptionalPropertyTypes now?

@JamieMagee JamieMagee mentioned this pull request Mar 12, 2023
Open
@RahulGautamSingh
Copy link
Collaborator Author

Are there more changes required, or can you enable exactOptionalPropertyTypes now?

Many more :) There are too many changes so I am dividing them across PRs.

viceice
viceice requested changes Mar 12, 2023
View reviewed changes
lib/modules/datasource/galaxy-collection/index.ts Outdated Show resolved Hide resolved
lib/modules/datasource/docker/index.ts Show resolved Hide resolved
lib/workers/repository/update/pr/index.ts Outdated Show resolved Hide resolved
lib/workers/repository/update/pr/index.ts Outdated Show resolved Hide resolved
@RahulGautamSingh @viceice
Apply suggestions from code review
0ef5db7 
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
viceice
viceice reviewed Mar 19, 2023
View reviewed changes
lib/modules/platform/types.ts Outdated Show resolved Hide resolved
lib/modules/platform/util.ts Outdated Show resolved Hide resolved
@viceice viceice enabled auto-merge March 19, 2023 16:06
@viceice viceice added this pull request to the merge queue Mar 19, 2023
@viceice viceice merged commit 1013302 into renovatebot:main Mar 19, 2023
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 35.14.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@nikolaik nikolaik mentioned this pull request Mar 23, 2023
Merged
6 tasks
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@viceice viceice viceice approved these changes

@JamieMagee JamieMagee JamieMagee left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@RahulGautamSingh @renovate-release @JamieMagee @viceice