Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add support for PAT in Bitbucket Server. Closes #14900 #20974

Merged
merged 1 commit into from
Mar 16, 2023

Conversation

aulisius
Copy link
Contributor

Changes

This PR allows users to specify PAT for Bitbucket server as an alternative to username/password

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@aulisius aulisius changed the title Add support for PAT in Bitbucket Server. Closes #14900 fix: Add support for PAT in Bitbucket Server. Closes #14900 Mar 16, 2023
@aulisius aulisius force-pushed the bitbucket-server-pat-support branch from 96913a8 to 1cfdf1a Compare March 16, 2023 03:41
@rarkins rarkins enabled auto-merge March 16, 2023 05:21
@rarkins rarkins added this pull request to the merge queue Mar 16, 2023
Merged via the queue into renovatebot:main with commit d739141 Mar 16, 2023
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 35.9.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@aulisius aulisius deleted the bitbucket-server-pat-support branch March 16, 2023 07:04
@Churro
Copy link
Collaborator

Churro commented Mar 16, 2023

Has this actually been tested?

I'm wondering where's the code that actually uses the token because e.g. this piece still says password only:

auth: `${opts.username}:${opts.password}`,

or here:
repoUrl.password = opts.password!;

@viceice
Copy link
Member

viceice commented Mar 16, 2023

@rarkins we should revert this, as it's not working as intended

@rarkins
Copy link
Collaborator

rarkins commented Mar 16, 2023

Sorry!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants