fix(deps/luxon): handle null return type in DateTime.toISO() #21428
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
DateTime.toISO()
fn are validContext
DateTime.toISO()
now returnsnull | string
.null
is returned only when an invalid date is passed. We are using valid dates everywhere so a non-null assertion should do the jobnull
return type optional but I think we should keep the return type as it will prevent us from accidentally passing date objects/strings to the fn without validatingDocumentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: