Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): lock file maintenance #22224

Merged
merged 7 commits into from
Aug 1, 2023
Merged

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented May 15, 2023

Mend Renovate

This PR contains the following updates:

Update Change
lockFileMaintenance All locks refreshed

🔧 This Pull Request updates lock files to use the latest dependency versions.


Configuration

📅 Schedule: Branch creation - "before 4am on Monday" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Enabled.

Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot enabled auto-merge May 15, 2023 00:47
renovate-approve[bot]
renovate-approve bot previously approved these changes May 15, 2023
renovate-approve-2[bot]
renovate-approve-2 bot previously approved these changes May 15, 2023
@renovate renovate bot force-pushed the renovate/lock-file-maintenance branch from 364f397 to 71b8d2b Compare May 15, 2023 01:36
@rarkins
Copy link
Collaborator

rarkins commented May 15, 2023

yarn run v1.22.19
$ cross-env LOG_LEVEL=fatal GIT_ALLOW_PROTOCOL=file jest --logHeapUsage --ci --coverage true
Error [ERR_REQUIRE_ESM]: require() of ES Module /home/runner/work/renovate/renovate/node_modules/string-width/index.js from /home/runner/work/renovate/renovate/node_modules/cliui/build/index.cjs not supported.
Instead change the require of index.js in /home/runner/work/renovate/renovate/node_modules/cliui/build/index.cjs to a dynamic import() which is available in all CommonJS modules.
    at Object.<anonymous> (/home/runner/work/renovate/renovate/node_modules/cliui/build/index.cjs:291:21)
    at Object.<anonymous> (/home/runner/work/renovate/renovate/node_modules/yargs/build/index.cjs:1:60678)
    at Object.<anonymous> (/home/runner/work/renovate/renovate/node_modules/yargs/index.cjs:5:30)
    at _yargs (/home/runner/work/renovate/renovate/node_modules/jest-cli/build/run.js:30:39)
    at buildArgv (/home/runner/work/renovate/renovate/node_modules/jest-cli/build/run.js:143:26)
    at Object.run (/home/runner/work/renovate/renovate/node_modules/jest-cli/build/run.js:[11](https://github.com/renovatebot/renovate/actions/runs/4975581326/jobs/8902885927?pr=22224#step:8:12)8:24)
    at Object.<anonymous> (/home/runner/work/renovate/renovate/node_modules/jest-cli/bin/jest.js:16:17)
    at Object.<anonymous> (/home/runner/work/renovate/renovate/node_modules/jest/bin/jest.js:[12](https://github.com/renovatebot/renovate/actions/runs/4975581326/jobs/8902885927?pr=22224#step:8:13):3)
error Command failed with exit code 1.

renovate-approve-2[bot]
renovate-approve-2 bot previously approved these changes May 15, 2023
renovate-approve[bot]
renovate-approve bot previously approved these changes May 15, 2023
@renovate renovate bot force-pushed the renovate/lock-file-maintenance branch 2 times, most recently from d0f4904 to 2aadc9a Compare May 15, 2023 14:45
@renovate renovate bot force-pushed the renovate/lock-file-maintenance branch from 2aadc9a to 60cb1f7 Compare May 15, 2023 18:34
renovate-approve[bot]
renovate-approve bot previously approved these changes May 15, 2023
renovate-approve-2[bot]
renovate-approve-2 bot previously approved these changes May 15, 2023
@viceice
Copy link
Member

viceice commented May 15, 2023

again type issues, this time it's minipass 😕

renovate-approve[bot]
renovate-approve bot previously approved these changes May 15, 2023
renovate-approve-2[bot]
renovate-approve-2 bot previously approved these changes May 15, 2023
renovate-approve[bot]
renovate-approve bot previously approved these changes May 15, 2023
renovate-approve-2[bot]
renovate-approve-2 bot previously approved these changes May 15, 2023
rarkins
rarkins previously approved these changes May 18, 2023
@rarkins
Copy link
Collaborator

rarkins commented May 18, 2023

❯ yarn why string-width
yarn why v1.22.19
[1/4] 🤔  Why do we have the module "string-width"...?
[2/4] 🚚  Initialising dependency graph...
warning Resolution field "@sinonjs/fake-timers@10.0.2" is incompatible with requested version "@sinonjs/fake-timers@^9.1.2"
[3/4] 🔍  Finding dependency...
[4/4] 🚡  Calculating file sizes...
=> Found "string-width@5.1.2"
info Reasons this module exists
   - "lint-staged#cli-truncate" depends on it
   - Hoisted from "lint-staged#cli-truncate#string-width"
   - Hoisted from "glob#jackspeak#@isaacs#cliui#string-width"
   - Hoisted from "glob#jackspeak#@isaacs#cliui#wrap-ansi#string-width"
info Disk size without dependencies: "96KB"
info Disk size with unique dependencies: "176KB"
info Disk size with transitive dependencies: "196KB"
info Number of shared dependencies: 4
✨  Done in 0.31s.

We depend directly on "lint-staged": "13.2.2".
lint-staged depends on cli-truncate "^3.1.0", which resolves to 3.1.0.
cli-truncate has been ESM-only since 3.0.0.

lint-staged became ESM-only in lint-staged/lint-staged#1038 which was v12.0.0.

In short, we have been using an ESM-only module as a dev dependency ever since lint-staged was introduced in #19388

@viceice
Copy link
Member

viceice commented May 25, 2023

❯ yarn why string-width
yarn why v1.22.19
[1/4] 🤔  Why do we have the module "string-width"...?
[2/4] 🚚  Initialising dependency graph...
warning Resolution field "@sinonjs/fake-timers@10.0.2" is incompatible with requested version "@sinonjs/fake-timers@^9.1.2"
[3/4] 🔍  Finding dependency...
[4/4] 🚡  Calculating file sizes...
=> Found "string-width@5.1.2"
info Reasons this module exists
   - "lint-staged#cli-truncate" depends on it
   - Hoisted from "lint-staged#cli-truncate#string-width"
   - Hoisted from "glob#jackspeak#@isaacs#cliui#string-width"
   - Hoisted from "glob#jackspeak#@isaacs#cliui#wrap-ansi#string-width"
info Disk size without dependencies: "96KB"
info Disk size with unique dependencies: "176KB"
info Disk size with transitive dependencies: "196KB"
info Number of shared dependencies: 4
✨  Done in 0.31s.

We depend directly on "lint-staged": "13.2.2".
lint-staged depends on cli-truncate "^3.1.0", which resolves to 3.1.0.
cli-truncate has been ESM-only since 3.0.0.

lint-staged became ESM-only in lint-staged/lint-staged#1038 which was v12.0.0.

In short, we have been using an ESM-only module as a dev dependency ever since lint-staged was introduced in #19388

this isn't a bad thing as long as it works.

the issue seems to be a too wide range on string-width somewhere, so the wrong version is hoisted. it can be resolved by depending on last non esm version directly.

@renovate renovate bot force-pushed the renovate/lock-file-maintenance branch 2 times, most recently from 8cd8228 to c56166c Compare July 6, 2023 06:25
@renovate renovate bot force-pushed the renovate/lock-file-maintenance branch from c56166c to d0242aa Compare July 6, 2023 08:10
rarkins
rarkins previously approved these changes Jul 6, 2023
@rarkins
Copy link
Collaborator

rarkins commented Jul 6, 2023

@viceice
image

@viceice
Copy link
Member

viceice commented Aug 1, 2023

the package @isaacs/cliui@^8.0.2 is causing the trouble.
image

it causes yarm to do some strange hoisting

@viceice
Copy link
Member

viceice commented Aug 1, 2023

@renovate renovate bot added this pull request to the merge queue Aug 1, 2023
Merged via the queue into main with commit 7222dc9 Aug 1, 2023
@viceice viceice deleted the renovate/lock-file-maintenance branch August 1, 2023 11:33
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 36.27.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants