fix: Renovate JSON schema allows invalid package rules #26484

[1999]

Changes

JSON schema generated by tools/docs/schema.ts will now have additional additionalProperties: false for arrays items which will prevent arbitrary configuration objects like {"foo": "bar"}.

Context

This change is a follow-up to discussion in #26484

Documentation (please check one with an [x])

• I have updated the documentation, or
• No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

• Code inspection only, or
• Newly added/modified unit tests, or
• No unit tests but ran on a real repository, or
• Both unit tests + ran on a real repository

Neither of those. I ran pnpm release:prepare and used the generated JSON schema from tmp/docs/renovate-schema.json in JSON schema validator. I took most of the examples from Renovate configuration page and made sure the JSON examples are still valid.

[1999]

Can make it more specific for "packageRules" if that's required.

[rarkins]

When validating this repo's renovate.json I now get these errors:

[1999]

@rarkins yeah, that's what I don't quite understand. For instance, "versioning" is not listed in the "packageRules" in Renovate configuration page but it is used in renovate.json for this repo. Does it mean that "versioning" hasn't been documented yet or something else?

[rarkins]

versioning is documented at the root level. There are some options which should exist only within the root, only within packageRules, or either is ok (such as enabled, or semanticCommitType). Right now we don't have that classification though

[1999]

is it safe to assume that whenever an option has globalOnly: true it can only be used on a top level, and otherwise it can be used in both top-level and packageRules? I'm just trying to understand if it's feasible to update my PR to reflect this.

[rarkins]

globalOnly=true options cannot be used in repository config

[rarkins]

Do not merge - broken

[1999]

There are some options which should exist only within the root, only within packageRules, or either is ok

@rarkins is there a list of the options that can be used in both places or that can be used in only top-level?

[rarkins]

No

[1999]

Okies. It doesn't sound like you're interested in keeping public schema updated. I will close this PR and put the schema into our private repository so that we could use it instead of the public one. Should you need any help with the public schema, don't hesitate to at-mention me.