Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vulnerabilities): describe last_affected version as ecosystem-specific version constraint #27363

Merged
merged 1 commit into from
Feb 16, 2024

Conversation

Churro
Copy link
Collaborator

@Churro Churro commented Feb 16, 2024

Changes

Ensures that Maven version ranges are used in allowedVersions constraints when OSV vulnerabilities specify an ecosystem-specific last_affected version. This prevents an Aggregate error exception that was thrown when advisories specify non-semver compatible versions, such as 1.2.1.2-jre17 (see discussion).

Of the OSV-supported ecosystems, this change is only required for maven and nuget. Support for nuget is missing for now as it depends on support for nuget version ranges being available.

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

Test repo: renovate-demo/renovate-osv-ecosystem-lastaffected#1

Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need to improve later to use the lowest fixed version somehow

@viceice viceice added this pull request to the merge queue Feb 16, 2024
Merged via the queue into renovatebot:main with commit 88ab15c Feb 16, 2024
35 checks passed
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 37.192.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants