fix(npm): replace pnpm overrides in right position

[viceice]

Changes

Replace pnpm overrides deps on right position

• regression of feat: support pnpm.overrides #28199

Context

• PNPM overrides completely break renovate updates #28605

Documentation (please check one with an [x])

• I have updated the documentation, or
• No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

• Code inspection only, or
• Newly added/modified unit tests, or
• No unit tests but ran on a real repository, or
• Both unit tests + ran on a real repository

[rarkins]

Can we wait for a reproduction repo to verify it against?

[viceice]

Can we wait for a reproduction repo to verify it against?

https://github.com/containerbase/base/blob/b95329c58c0437b23424da896e3df463b6d9a7a6/package.json#L34

will convert to pnpm.overrides to validate after forking 🤗

[viceice]

working sample with this PR

• build(deps): update dependency esbuild to v0.20.2 (viceicebot) renovate-reproductions/base#2

[viceice]

failing on app

• Dependency Dashboard renovate-reproductions/28605-pnpm-overrides#3
• https://developer.mend.io/github/renovate-reproductions/28605-pnpm-overrides/-/job/16dcc46f-539e-4a0f-ade4-08f7324cd4fb

DEBUG: latest commit (branch="renovate/esbuild-0.x")
{
  "branchName": "main"
  "latestCommitDate": "2024-04-24T08:35:35+02:00"
}

DEBUG: manager.getUpdatedPackageFiles() reuseExistingBranch=false (branch="renovate/esbuild-0.x")
DEBUG: npm.updateDependency(): overrides.esbuild = 0.20.2 (branch="renovate/esbuild-0.x")
DEBUG: updateDependency error (branch="renovate/esbuild-0.x")
{
  "err": {
    "message": "Cannot read properties of undefined (reading 'esbuild')",
    "stack": "TypeError: Cannot read properties of undefined (reading 'esbuild')\n    at updateDependency (/usr/local/renovate/lib/modules/manager/npm/update/dependency/index.ts:162:58)\n    at getUpdatedPackageFiles (/usr/local/renovate/lib/workers/repository/update/branch/get-updated.ts:221:30)\n    at processTicksAndRejections (node:internal/process/task_queues:95:5)\n    at processBranch (/usr/local/renovate/lib/workers/repository/update/branch/index.ts:460:19)\n    at writeUpdates (/usr/local/renovate/lib/workers/repository/process/write.ts:166:17)\n    at update (/usr/local/renovate/lib/workers/repository/process/extract-update.ts:214:11)\n    at Object.renovateRepository (/usr/local/renovate/lib/workers/repository/index.ts:87:19)\n    at attributes.repository (/usr/local/renovate/lib/workers/global/index.ts:217:11)\n    at start (/usr/local/renovate/lib/workers/global/index.ts:202:7)\n    at /usr/local/renovate/lib/renovate.ts:18:22"
  }
}

[karlhorky]

working sample with this PR

• build(deps): update dependency esbuild to v0.20.2 (viceicebot) renovate-reproductions/base#2

Oh TIL that there's a renovate-reproductions/base repo, this looks very useful 👀 ❤️

• github.com/renovate-reproductions/base/

Would be great to have this as a part of the open source issue / discussion creation process, to make it super easy to create good reproductions for Renovate

[Algram]

@viceice Thanks for the speedy help! LGTM!

[HonkingGoose]

working sample with this PR

• build(deps): update dependency esbuild to v0.20.2 (viceicebot) renovate-reproductions/base#2

Oh TIL that there's a renovate-reproductions/base repo, this looks very useful 👀 ❤️

* [github.com/renovate-reproductions/base/](https://github.com/renovate-reproductions/base/)

Would be great to have this as a part of the open source issue / discussion creation process, to make it super easy to create good reproductions for Renovate

See this discussion:

• Minimal reproduction instructions/templates #28614

[renovate-release]

🎉 This PR is included in version 37.320.1 🎉

The release is available on:

• GitHub release
• npm package (@latest dist-tag)
• 37.320.1

Your semantic-release bot 📦🚀