-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(self-hosted): autodiscoverRepoSort
and autodiscoverRepoOrder
#28738
feat(self-hosted): autodiscoverRepoSort
and autodiscoverRepoOrder
#28738
Conversation
Co-authored-by: Rhys Arkins <rhys@arkins.net>
…' of https://github.com/RahulGautamSingh/renovate into feat/gitea-autodicovers
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I need to remember to update my config 🙃
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like wrong types, considering the default value is null
. Please also massage the X variables to the new versions prior to env parsing.
This comment was marked as resolved.
This comment was marked as resolved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@viceice any reason why we can't default these to string values and skip null
?
because we then always send those values instead of skipping them. |
What's wrong with always sending them? Does it change the default behavior? It would simplify our config to always send |
it probably changes the default behavior. if we set a default value, then we need to make types strict, so we don't need to check for null or undefined. otherwise it doesn't improve anything. |
Yes, I was hoping to avoid null/undefined but I guess it doesn't matter too much |
🎉 This PR is included in version 37.346.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
sadly this broke docs again |
Changes
Convert the
RENOVATE_X_AUTODISCOVER_REPO_SORT
andRENOVATE_X_AUTODISCOVER_REPO_ORDER
to self hosted config options.Context
Closes: #28717
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: