Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(self-hosted): autodiscoverRepoSort and autodiscoverRepoOrder #28738

Merged
merged 13 commits into from
May 6, 2024

Conversation

RahulGautamSingh
Copy link
Collaborator

Changes

Convert the RENOVATE_X_AUTODISCOVER_REPO_SORT and RENOVATE_X_AUTODISCOVER_REPO_ORDER to self hosted config options.

Context

Closes: #28717

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

docs/usage/self-hosted-configuration.md Outdated Show resolved Hide resolved
docs/usage/self-hosted-configuration.md Outdated Show resolved Hide resolved
docs/usage/self-hosted-configuration.md Outdated Show resolved Hide resolved
docs/usage/self-hosted-configuration.md Outdated Show resolved Hide resolved
lib/modules/platform/gitea/index.ts Outdated Show resolved Hide resolved
Co-authored-by: Rhys Arkins <rhys@arkins.net>
lib/config/options/index.ts Outdated Show resolved Hide resolved
lib/config/options/index.ts Outdated Show resolved Hide resolved
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need to remember to update my config 🙃

lib/modules/platform/types.ts Outdated Show resolved Hide resolved
Copy link
Collaborator

@rarkins rarkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like wrong types, considering the default value is null. Please also massage the X variables to the new versions prior to env parsing.

lib/modules/platform/types.ts Outdated Show resolved Hide resolved
lib/workers/global/autodiscover.ts Show resolved Hide resolved
@RahulGautamSingh

This comment was marked as resolved.

@RahulGautamSingh RahulGautamSingh requested review from viceice, rarkins, secustor and HonkingGoose and removed request for viceice and rarkins May 2, 2024 19:25
Copy link
Collaborator

@rarkins rarkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@viceice any reason why we can't default these to string values and skip null?

@viceice
Copy link
Member

viceice commented May 6, 2024

@viceice any reason why we can't default these to string values and skip null?

because we then always send those values instead of skipping them.

@rarkins
Copy link
Collaborator

rarkins commented May 6, 2024

What's wrong with always sending them? Does it change the default behavior? It would simplify our config to always send

@viceice
Copy link
Member

viceice commented May 6, 2024

What's wrong with always sending them? Does it change the default behavior? It would simplify our config to always send

it probably changes the default behavior.

if we set a default value, then we need to make types strict, so we don't need to check for null or undefined. otherwise it doesn't improve anything.

@rarkins
Copy link
Collaborator

rarkins commented May 6, 2024

Yes, I was hoping to avoid null/undefined but I guess it doesn't matter too much

@rarkins rarkins enabled auto-merge May 6, 2024 18:15
@rarkins rarkins added this pull request to the merge queue May 6, 2024
Merged via the queue into renovatebot:main with commit 10a4a8b May 6, 2024
37 checks passed
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 37.346.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@viceice
Copy link
Member

viceice commented May 7, 2024

sadly this broke docs again

renovatebot/renovatebot.github.io#478

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Convert experimental autodiscover env to config options
5 participants