Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(homebrew): handle new github archive url format #29138

Merged
merged 9 commits into from
May 20, 2024
Merged

fix(homebrew): handle new github archive url format #29138

merged 9 commits into from
May 20, 2024

Commits on May 18, 2024

  1. fix(homebrew): handle new github archive url format 

    Old archive urls were in form: https://github.com/<owner/<repo>/archive/<tag>.tar.gz
New ones are in form: https://github.com/<owner/<repo>/archive/refs/tags/<tag>.tar.gz

So with the current parsing `currentValue` ends up being filled with
the `refs` string instead of the tag value.

This change handles both forms by checking the length of the url paths
slice.
    @nikaro
    nikaro committed May 18, 2024
    Configuration menu
    Copy the full SHA
    924e449 View commit details
    Browse the repository at this point in the history

  2. tests(homebrew): update archive urls to new format

    @nikaro
    nikaro committed May 18, 2024
    Configuration menu
    Copy the full SHA
    f4e53df View commit details
    Browse the repository at this point in the history

Commits on May 19, 2024

  1. tests(homebrew): add test case for old url format

    @nikaro
    nikaro committed May 19, 2024
    Configuration menu
    Copy the full SHA
    c620360 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into fix/homebrew-url-path-parsing

    @nikaro
    nikaro committed May 19, 2024
    Configuration menu
    Copy the full SHA
    664d469 View commit details
    Browse the repository at this point in the history

  3. refactor(homebrew): do return null early

    @nikaro
    nikaro committed May 19, 2024
    Configuration menu
    Copy the full SHA
    9a96b67 View commit details
    Browse the repository at this point in the history

  4. tests(homebrew): check null return on wrong archive format

    @nikaro
    nikaro committed May 19, 2024
    Configuration menu
    Copy the full SHA
    523fcdd View commit details
    Browse the repository at this point in the history

  5. tests(homebrew): add test case for old url format update

    @nikaro
    nikaro committed May 19, 2024
    Configuration menu
    Copy the full SHA
    6af9d09 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'main' into fix/homebrew-url-path-parsing

    @nikaro
    nikaro committed May 19, 2024
    Configuration menu
    Copy the full SHA
    a48ea01 View commit details
    Browse the repository at this point in the history

Commits on May 20, 2024

  1. refactor: simplify check

    @nikaro
    nikaro committed May 20, 2024
    Configuration menu
    Copy the full SHA
    08bd240 View commit details
    Browse the repository at this point in the history