fix: Correct digest resolution when the replacementName and replacementVersion options are defined #29164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Tries to get the digest for the artifact specified in the replacementName option instead of the lookupName because the new artifact might be a different one to the original one * Sets the current digest on undifined when iterates over a replacement because the new image might be different to the original and the getDigest function use it with the replacementName option.
…ves the correct parameters
…shouldn't be modified
rarkins
added
the
auto:reproduction
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
rarkins
reviewed
May 22, 2024
Removed from an old code because it doesn't represent the correct use case.
viceice
previously approved these changes
May 22, 2024
viceice
reviewed
May 22, 2024
viceice
reviewed
May 22, 2024
viceice
approved these changes
May 22, 2024
rarkins
approved these changes
May 22, 2024
|
🎉 This PR is included in version 37.374.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
The lookupName and currentDigest values are set as undefined when a replacementName update is running because the new image may differ from the original one.
Added new test case that validates the correct getDigest function call
Context
Discussion #27728
Closes #20304
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: