Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(pip-compile): Correctly report errors when a lock file is unchanged #29363

Merged
merged 2 commits into from
May 31, 2024
Merged

fix(pip-compile): Correctly report errors when a lock file is unchanged #29363

merged 2 commits into from
May 31, 2024

Commits on May 30, 2024

  1. fix(pip-compile): Correctly report errors when a lock file is unchanged 

    The pip-compile manager can update multiple lock files when a single
input file changes, however the manager would short-circuit and return
null as soon as a single lock file remained unchanged after being
re-compiled.

This was causing two issues:
1. Updates to a later lock file could be missed.  This is fairly
   unlikely since the manager trys not to re-compile lock files for
   which the input haven't changed.
2. Errors in one lock file update could be swolloed if a later lock file
   update succeeded but made no changes.  This scenario was quite
   likely, especially in the case where one lock file depends on another
   since the first failure will result in an unchanged upstream lock
   file.

This removes the short-circuit behavior so that the manager will
re-compile all of the lock files that depend on the changed input file
no matter what.
    @mbudnek
    mbudnek committed May 30, 2024
    Configuration menu
    Copy the full SHA
    79325da View commit details
    Browse the repository at this point in the history

  2. Return null if no changes

    @mbudnek
    mbudnek committed May 30, 2024
    Configuration menu
    Copy the full SHA
    98c763c View commit details
    Browse the repository at this point in the history