Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(vulnerabilities): do not force exact patch version for PyPI datasource in GitHub alerts #29586

Merged
merged 1 commit into from
Jun 11, 2024
Merged

fix(vulnerabilities): do not force exact patch version for PyPI datasource in GitHub alerts #29586

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/workers/repository/init/__snapshots__/vulnerability.spec.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ An issue was discovered in FasterXML jackson-databind prior to 2.7.9.4, 2.8.11.2
exports[`workers/repository/init/vulnerability detectVulnerabilityAlerts() returns pip alerts 1`] = `
[
{
"allowedVersions": "==2.2.1.0",
"allowedVersions": ">=2.2.1.0",
"force": {
"branchTopic": "{{{datasource}}}-{{{depName}}}-vulnerability",
"commitMessageSuffix": "[SECURITY]",
Expand Down
2 changes: 1 addition & 1 deletion lib/workers/repository/init/vulnerability.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,7 +207,7 @@ export async function detectVulnerabilityAlerts(
// TODO: types (#22198)
const allowedVersions =
datasource === PypiDatasource.id
? `==${val.firstPatchedVersion!}`
? `>=${val.firstPatchedVersion!}`
rarkins marked this conversation as resolved.
Show resolved Hide resolved
: val.firstPatchedVersion;
const matchFileNames =
datasource === GoDatasource.id
Expand Down