Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update emojibase monorepo to v15.3.2 #29592

Merged
merged 2 commits into from
Jun 14, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 0 additions & 9 deletions lib/util/emoji.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -51,15 +51,6 @@ describe('util/emoji', () => {
expect(result).toEqual(text);
});

describe('unsupported characters', () => {
const unsupported = '🫠';

it('uses replacement character', () => {
setEmojiConfig({ unicodeEmoji: false });
expect(unemojify(unsupported)).toBe('�');
});
});

it('converts warning emoji to shortcode', () => {
setEmojiConfig({ unicodeEmoji: false });
const emoji = '⚠️';
Expand Down
2 changes: 1 addition & 1 deletion lib/util/emoji.ts
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ export function unemojify(text: string): string {
return text.replace(emojiRegex, (emoji) => {
const hexCode = stripHexCode(fromUnicodeToHexcode(emoji));
const shortCode = shortCodesByHex.get(hexCode);
return shortCode ?? '�';
return shortCode ?? /* istanbul ignore next */ '�';
});
}

Expand Down
4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -190,7 +190,7 @@
"email-addresses": "5.0.0",
"emoji-regex": "10.3.0",
"emojibase": "15.3.1",
"emojibase-regex": "15.3.1",
"emojibase-regex": "15.3.2",
"extract-zip": "2.0.1",
"find-packages": "10.0.4",
"find-up": "5.0.0",
Expand Down Expand Up @@ -313,7 +313,7 @@
"callsite": "1.0.0",
"common-tags": "1.8.2",
"conventional-changelog-conventionalcommits": "7.0.2",
"emojibase-data": "15.3.1",
"emojibase-data": "15.3.2",
"eslint": "8.57.0",
"eslint-formatter-gha": "1.5.0",
"eslint-import-resolver-typescript": "3.6.1",
Expand Down
20 changes: 10 additions & 10 deletions pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.