feat(mix): Support private hex repos/registries #29775

bryannaegele · 2024-06-20T03:55:40Z

Changes

This adds support to the mix manager to add private hex repos/registries via registryAliases for mapping and hostRules for authentication.

Context

This is the companion to #29756 and dependent on that change. Splitting the manager and datasource work per request in #29756. When combined, this will enable support for private repos/registries such as oban pro.

Documentation (please check one with an [x])

I have updated the documentation, or
No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

Code inspection only, or
Newly added/modified unit tests, or
No unit tests but ran on a real repository, or
Both unit tests + ran on a real repository

Tested in combination with #29756. This will not fully work without that code.

lib/modules/manager/mix/artifacts.ts

Co-authored-by: Michael Kriese <michael.kriese@visualon.de>

bryannaegele · 2024-08-19T17:07:19Z

Feedback should be addressed 👍🏻

viceice · 2024-08-21T12:13:42Z

lib/modules/manager/mix/artifacts.spec.ts

+        file: { type: 'addition', path: 'mix.lock', contents: 'New mix.lock' },
+      },
+    ]);
+    expect(execSnapshots).toMatchObject([


i don't see a test for the mix repo.add ... command

The test is to check that we don't do that in this case. does not add registries configured in registryAliases but no token in hostRules

then add a test for it

viceice · 2024-08-21T12:14:24Z

lib/modules/manager/mix/artifacts.ts

@@ -75,26 +78,50 @@ export async function updateArtifacts({

  for (const { packageName } of updatedDeps) {
    if (packageName) {
-      const [, organization] = packageName.split(':');
+      const [, organization, ,] = packageName.split(':');


Suggested change

const [, organization, ,] = packageName.split(':');

const [, organization] = packageName.split(':');

not needed

I don't understand the suggestion. This wants to extract the second value in whatever is returned. The packageName when split can be 2 or 3 elements in length. The suggestion only works when array of length 2 is returned.

no, the split returns all elements, but the array destruction will only return the first two and ignore the rest.

https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/Destructuring_assignment

viceice · 2024-08-21T12:15:21Z

lib/modules/manager/mix/artifacts.ts


-    return acc;
-  }, [] as string[]);
+      // istanbul ignore if: no good way to test


no, why? you can mock hostrule find properly

viceice · 2024-08-21T12:17:44Z

lib/modules/manager/mix/utils.ts

+    return packageName;
+  }
+
+  const [, repoName, ,] = packageName.split(':');


Suggested change

const [, repoName, ,] = packageName.split(':');

const [, repoName] = packageName.split(':');

I don't understand the suggestion. This wants to extract the second value in whatever is returned.

viceice · 2024-08-21T12:19:12Z

lib/modules/manager/mix/readme.md

+  registryAliases: {
+    oban: 'https://getoban.pro/repo',
+  },


this should be scoped to mix manager, otherwise it will interferre with other managers using registry aliases

So there needs to be a further nesting of the object? I didn't see any examples of that in other managers

viceice · 2024-08-21T12:20:12Z

lib/modules/manager/mix/index.ts

+  registryAliases: {
+    hexpm: 'https://hex.pm',
+  },


why is this needed

We need the URL for the hexpm registry, which is the default, so we put it into the default config. This is merged with anything the user has supplied, giving us a complete lookup of the URLs. This has an added benefit that if a company wished to host an internal proxy registry, no updates are needed to their mix files; they have a way to point someplace else.

you should not add a default url, the datasource has it already, so only set registry url if it's not the default

viceice · 2024-08-21T12:21:47Z

lib/modules/manager/mix/extract.ts

          if (requirement?.startsWith('==')) {
            dep.currentVersion = requirement.replace(regEx(/^==\s*/), '');
          }
+
+          if (organization) {
+            dep.packageName = `org:${organization}:${app}`;


this is used by the hex datasource, so needs changes there too

renovate/lib/modules/datasource/hex/index.ts

Line 45 in 302718f

const [hexPackageName, organizationName] = packageName.split(':');

That is in the other PR. You requested to split them so neither PR will work on its own

then don't change package name in this PR, do the package name change in a separate refactor PR

bryannaegele mentioned this pull request Jun 20, 2024

feat(hex): use registry v2 for packages rather than hex.pm http API #29756

Open

6 tasks

bryannaegele marked this pull request as draft June 20, 2024 15:27

bryannaegele marked this pull request as ready for review June 24, 2024 17:23

HonkingGoose mentioned this pull request Jul 25, 2024

v39 planning #25608

Open

7 tasks

This comment has been minimized.

Sign in to view

viceice reviewed Aug 19, 2024

View reviewed changes

lib/modules/manager/mix/artifacts.ts Outdated Show resolved Hide resolved

lib/modules/manager/mix/artifacts.ts Outdated Show resolved Hide resolved

lib/modules/manager/mix/artifacts.ts Outdated Show resolved Hide resolved

lib/modules/manager/mix/artifacts.ts Outdated Show resolved Hide resolved

bryannaegele and others added 7 commits August 19, 2024 11:02

Support private mix repos

d63da36

codecov improvements

85c96b8

util tests are sync

6038fa7

Update lib/modules/manager/mix/artifacts.ts

be28694

Co-authored-by: Michael Kriese <michael.kriese@visualon.de>

Update lib/modules/manager/mix/artifacts.ts

9adab66

Co-authored-by: Michael Kriese <michael.kriese@visualon.de>

Address PR code style feedback

6b555a7

nothing to return

6c293a1

bryannaegele force-pushed the feat/29622-mix-repo-support branch from 36e3f93 to 6c293a1 Compare August 19, 2024 17:02

rarkins requested a review from viceice August 21, 2024 09:38

Merge branch 'main' into feat/29622-mix-repo-support

c9701c6

viceice reviewed Aug 21, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(mix): Support private hex repos/registries #29775

feat(mix): Support private hex repos/registries #29775

bryannaegele commented Jun 20, 2024

This comment has been minimized.

bryannaegele commented Aug 19, 2024

viceice Aug 21, 2024

bryannaegele Aug 21, 2024 •

edited

Loading

viceice Aug 21, 2024

viceice Aug 21, 2024

bryannaegele Aug 21, 2024

viceice Aug 21, 2024

viceice Aug 21, 2024

viceice Aug 21, 2024

bryannaegele Aug 21, 2024

viceice Aug 21, 2024

bryannaegele Aug 21, 2024

viceice Aug 21, 2024

bryannaegele Aug 21, 2024

viceice Aug 21, 2024

viceice Aug 21, 2024

bryannaegele Aug 21, 2024

viceice Aug 21, 2024

	const [, organization, ,] = packageName.split(':');
	const [, organization] = packageName.split(':');

	const [, repoName, ,] = packageName.split(':');
	const [, repoName] = packageName.split(':');

feat(mix): Support private hex repos/registries #29775

Are you sure you want to change the base?

feat(mix): Support private hex repos/registries #29775

Conversation

bryannaegele commented Jun 20, 2024

Changes

Context

Documentation (please check one with an [x])

How I've tested my work (please select one)

This comment has been minimized.

bryannaegele commented Aug 19, 2024

Choose a reason for hiding this comment

bryannaegele Aug 21, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bryannaegele Aug 21, 2024 •

edited

Loading