-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(datasource/aws-rds): improve readme #29870
base: main
Are you sure you want to change the base?
docs(datasource/aws-rds): improve readme #29870
Conversation
} | ||
``` | ||
|
||
The above configuration will ...insert explanation of bits below... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need a maintainer suggestion for this line too. 😉
"customType": "regex", | ||
"fileMatch": [".+\\.tf$"], | ||
"matchStrings": [ | ||
"\\s*#\\s*renovate:\\s*amiFilter=(?<lookupName>.+?) depName=(?<depName>.*) versioning=(?<versioning>.*)\\s*.*_version\\s*=\\s*\"(?<currentValue>.*)\"" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
issue: Just saw this by accident. amiFilter
seems to be wrong here and a copy/paste error from the very beginning as we are updating RDS versions and not an AMI id.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you suggest the correct code? I don't understand this enough to fix it.
And thank you for the review comment! ❤️
Changes
aws-rds
datasource readme:Context
A user showed their config for "terraform + rds datasource + aurora-mysql", that should probably go in the docs.
They also said that the docs don't warn that by default the aws-rds datasource does not work with Amazon Aurora. So I'm warning about that in the docs too now.
Drive-by PR, not closing any issue with this, but it does resolve a bit of the discussion:
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: