Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(templates): allow upgrades in commitMessage and prTitle #29955

Merged
merged 11 commits into from
Jul 25, 2024

Conversation

amezin
Copy link
Contributor

@amezin amezin commented Jul 1, 2024

Changes

Allow access to upgrades in commitMessage and prTitle templates.

Context

#29546

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@rarkins rarkins marked this pull request as draft July 1, 2024 08:01
rarkins
rarkins previously requested changes Jul 4, 2024
Copy link
Collaborator

@rarkins rarkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you refactor this into a function first (with no functional changes), and then after apply this change?

@amezin amezin requested a review from rarkins July 7, 2024 15:29
@amezin amezin marked this pull request as ready for review July 22, 2024 21:12
@amezin
Copy link
Contributor Author

amezin commented Jul 22, 2024

It seems that existing tests didn't verify hasBaseBranches: true and separateMajorMinor: true cases (there are such updates in the tests, but their generated title was always thrown away and not checked)

@rarkins
Copy link
Collaborator

rarkins commented Jul 23, 2024

Can you link to the repository you tested against? I think we need to validate both the group and non-group cases

@amezin
Copy link
Contributor Author

amezin commented Jul 23, 2024

Can you link to the repository you tested against? I think we need to validate both the group and non-group cases

https://github.com/amezin/renovate-template-issues

@rarkins
Copy link
Collaborator

rarkins commented Jul 25, 2024

Awaitinv v38

@amezin
Copy link
Contributor Author

amezin commented Jul 25, 2024

Do you consider this to be a breaking change?

Should I switch the target branch to v38?

@rarkins rarkins enabled auto-merge July 25, 2024 14:41
@rarkins rarkins added this pull request to the merge queue Jul 25, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 25, 2024
@rarkins rarkins enabled auto-merge July 25, 2024 16:05
@rarkins rarkins added this pull request to the merge queue Jul 25, 2024
Merged via the queue into renovatebot:main with commit 08549e2 Jul 25, 2024
38 checks passed
@renovate-release
Copy link
Collaborator

🎉 This issue has been resolved in version 38.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants