-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(devbox): Add devbox manager and nixhub datasource and versioning #30002
base: main
Are you sure you want to change the base?
Conversation
- this is the output of running it locally jay-aye-see-kay/renovate-testing@50f957b - haven't tested lockfile maintenance yet - no working automated tests yet
Thanks @burritobill! Our team at at Jetify is excited to see this integration that Renovate will work with Devbox. I can confirm that the Nixhub APIs used here are correct and stable. |
lib/modules/manager/devbox/readme.md
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add links/URLs
lib/modules/manager/devbox/index.ts
Outdated
enabled: true, | ||
}; | ||
|
||
export const categories: Category[] = ['devbox', 'node']; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
export const categories: Category[] = ['devbox', 'node']; | |
export const categories: Category[] = ['node']; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I will just remove these categories, I'm unsure if it is even required?
|
||
let cmd = ''; | ||
if (updateConfig.config.isLockFileMaintenance) { | ||
cmd += 'devbox update'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
devbox will need adding to github.com/containerbase/base first
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does devbox update fully wipe/refresh the lock file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will add devbox to the containerbase repo now.
Yes it will recreate it if it is out of sync with the devbox.json
if (updateConfig.config.isLockFileMaintenance) { | ||
cmd += 'devbox update'; | ||
} else { | ||
cmd += 'devbox install'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does devbox install sync the lock file to the package file if they are out of sync?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes it does
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
after first round of reviews this PR should be split into 3 separate PR's.
- refactorings (if required)
- versioning
- datasource
- manager
My plan is to add devbox to the containerbase, then should I split this PR into the datasource and versioning PRs and then once those are merged I can make the manager PR as it relies on the other 2? |
My priorities at work are meaning that I probably won't be able to get back round to this PR for a few weeks, but I would appreciate if you can keep this one open for me until then. |
Changes
This PR adds a devbox manager https://www.jetify.com/devbox. Devbox is a local development tool
which creates local reproducible environments without docker containers.
Devbox uses Nixhub as it's datasource for releases, nixhub datasource and versioning code has been added.
Context
I am making these changes on behalf of Culture Amp as we are using renovate internally and have recently migrated to using devbox for our local developer environments.
This PR will ensure that all of our devbox.json files stay up to date with the rest of our repos.
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: