-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(gomod): rename depName
#30030
Conversation
As part of a prefactor for renovatebot#29575, we should make this change independently, to make the changes in renovatebot#29575 easier to review. This is required as we will be adding replacements for `gomod` and so we'll have both a `fromPackageName` and a `toPackageName`.
Closing, as keeping the name as |
I've re-opened as it appears that yes actually we do need to have the renaming of variables, as we do some pre-emptive checks i.e. https://github.com/jamietanna/renovate/blob/33a20bcc2a8ad9b35d63d1e99530eac776778bdc/lib/modules/manager/gomod/update.ts#L45 to make sure that the dependency is there, and if we reuse the |
Thank you! 🙇 |
🎉 This issue has been resolved in version 37.436.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Changes
Rename the
depName
variable, as in #29575 we will be adding replacements forgomod
and sowe'll have both a
fromPackageName
and atoPackageName
.Context
As part of a prefactor for #29575, we should make this change
independently, to make the changes in #29575 easier to review.
This is required as we will be adding replacements for
gomod
and sowe'll have both a
fromPackageName
and atoPackageName
.Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: