refactor(gomod): rename depName
#30030
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As part of a prefactor for renovatebot#29575, we should make this change independently, to make the changes in renovatebot#29575 easier to review. This is required as we will be adding replacements for `gomod` and so we'll have both a `fromPackageName` and a `toPackageName`.
6 tasks
rarkins
reviewed
Jul 4, 2024
viceice
previously approved these changes
Jul 4, 2024
rarkins
reviewed
Jul 4, 2024
|
Closing, as keeping the name as |
|
I've re-opened as it appears that yes actually we do need to have the renaming of variables, as we do some pre-emptive checks i.e. https://github.com/jamietanna/renovate/blob/33a20bcc2a8ad9b35d63d1e99530eac776778bdc/lib/modules/manager/gomod/update.ts#L45 to make sure that the dependency is there, and if we reuse the |
rarkins
approved these changes
Jul 20, 2024
|
Thank you! 🙇 |
|
🎉 This issue has been resolved in version 37.436.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Rename the
depNamevariable, as in #29575 we will be adding replacements forgomodand sowe'll have both a
fromPackageNameand atoPackageName.Context
As part of a prefactor for #29575, we should make this change
independently, to make the changes in #29575 easier to review.
This is required as we will be adding replacements for
gomodand sowe'll have both a
fromPackageNameand atoPackageName.Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: