Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): override glob, text-exclude #30117

Closed
wants to merge 3 commits into from
Closed

Conversation

rarkins
Copy link
Collaborator

@rarkins rarkins commented Jul 10, 2024

Changes

Uses pnpm.overrides to force upgrade glob and test-exclude.

Context

Reduce use of deprecated dependencies

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@rarkins rarkins requested review from viceice and secustor July 10, 2024 13:50
@rarkins
Copy link
Collaborator Author

rarkins commented Jul 10, 2024

The only documented breaking change in test-exclude v7 is that it requires Node 18 or greater: https://github.com/istanbuljs/test-exclude/releases/tag/test-exclude-v7.0.0

@rarkins
Copy link
Collaborator Author

rarkins commented Jul 10, 2024

It's possible that these are devDependencies-only, and maybe it's not worth the effort

@rarkins rarkins marked this pull request as draft July 10, 2024 14:43
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if it works as intended 🤷‍♂️

@rarkins rarkins closed this Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants