-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(manager): add inline script metadata (PEP 723) support #31266
Open
mkniewallner
wants to merge
8
commits into
renovatebot:main
Choose a base branch
from
mkniewallner:feat/add-pep723-manager
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat(manager): add inline script metadata (PEP 723) support #31266
mkniewallner
wants to merge
8
commits into
renovatebot:main
from
mkniewallner:feat/add-pep723-manager
+197
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkniewallner
force-pushed
the
feat/add-pep723-manager
branch
from
September 7, 2024 21:41
2d7fc72
to
0b21877
Compare
mkniewallner
commented
Sep 7, 2024
mkniewallner
force-pushed
the
feat/add-pep723-manager
branch
from
September 7, 2024 21:48
0b21877
to
5bd88c7
Compare
mkniewallner
commented
Sep 7, 2024
viceice
reviewed
Sep 8, 2024
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
viceice
reviewed
Sep 8, 2024
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
rarkins
reviewed
Sep 10, 2024
viceice
reviewed
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Add support for Python inline script metadata, also known as PEP 723.
Context
Closes #27889.
Both the regex and the transformation from commented out TOML to actual TOML have been adapted from the Python reference version. Per the recommendation in the linked discussion, since virtually any Python file can contain such metadata, to avoid slowing down Renovate,
fileMatch
defaults to an empty array.Documentation (please check one with an [x])
Just a note that I initially wanted to add a section similar to
pip-compile
to mention that we have an emptyfileMatch
by default, but I then realised there already is code in place to generate a default section for this case, as can be seen here.How I've tested my work (please select one)
I have verified these changes via:
Changes tested in https://github.com/mkniewallner/renovate-pep723, where:
requests
andrich
dependenciesrequests
in the 2 files were it is present was created