feat(azure): small improvements for PR assignees and reviewers (corre… #5601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viceice
reviewed
Feb 29, 2020
| @@ -128,6 +129,7 @@ If you need any further assistance then you can also [request help here](${confi | |||
| useDefaultBranch, | |||
| }); | |||
| logger.info({ pr: pr.displayNumber }, 'Onboarding PR created'); | |||
| await addAssigneesReviewers(config, pr); | |||
There was a problem hiding this comment.
@rarkins I think this should be done in separate pr.
There was a problem hiding this comment.
Yes, please separate this to another PR
There was a problem hiding this comment.
Updates related to second change removed with this commit. New PR opened for it here.
viceice
requested changes
Feb 29, 2020
…ctly assign when display name format is used)
JamieMagee
approved these changes
Mar 24, 2020
|
@viceice Needs your approval |
viceice
approved these changes
Mar 25, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ctly assign when display name format is used; also add assignees and reviewers for onboarding PR if assigness/reviewers have been provided as command line arguments)
For Azure PR assignees are added by doing a mention in a PR comment. Currently when the assignee is given by its "displayName" instead of its "uniqueName" the mention will not work correctly. For reviewers it is possible to configure the reviewers by both their "displayName" and "uniqueName", so the code change of this pull request applies the same logic for reviewers also to assignees. Being able to specify assignees by display name can be useful because Azure Devops pipelines provide the display name as an environment variable in a running pipeline, but not the unique name.