Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(npm): detect npm6/7 for npm install #8506

Merged
merged 4 commits into from
Feb 3, 2021
Merged

fix(npm): detect npm6/7 for npm install #8506

merged 4 commits into from
Feb 3, 2021

Conversation

rarkins
Copy link
Collaborator

@rarkins rarkins commented Feb 2, 2021

Changes:

Adds detection for npm 6 vs 7 when binarySource=docker

Context:

npm@7 just became latest and we should install npm@6 for any repo with a v1 lockFile

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added unit tests, or
  • Ran on a real repository

@rarkins rarkins requested review from JamieMagee and viceice February 2, 2021 17:56
viceice
viceice previously approved these changes Feb 2, 2021
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No tests 😕

@viceice
Copy link
Member

viceice commented Feb 2, 2021

ref #7474

@rarkins rarkins requested a review from viceice February 2, 2021 20:42
viceice
viceice previously approved these changes Feb 2, 2021
This reverts commit d38e9f3.
@rarkins rarkins merged commit 5d606db into master Feb 3, 2021
@rarkins rarkins deleted the fix/npm-install branch February 3, 2021 07:48
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 24.34.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants