Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small fixes in python block and new indenting rules #104

Merged
merged 3 commits into from
May 2, 2022

Conversation

duckdoom4
Copy link
Collaborator

  • Store should be allowed to have single character names

  • Allow multiple (tabs and) spaces between words

  • Make sure we catch all characters between 'python' and ':'

  • Don't use meta.embedded for the arguments since this will change the language and prevent indent

  • Moved them to the language config to keep them where they belong

  • Removed python keywords that are not available in Renpy code

  • Split rules to get a more clear overview

  • Special case for when in menu's

duckdoom4 added 2 commits May 2, 2022 14:41
* Store should be allowed to have single character names
* Allow multiple (tabs and) spaces between words
* Make sure we catch all characters between 'python' and ':'
* Don't use meta.embedded for the arguments since this will change the language and prevent indent
* Moved them to the language config to keep them where they belong
* Removed python keywords that are not available in Renpy code
* Split rules to get a more clear overview
* Special case for when in menu's
@LuqueDaniel LuqueDaniel self-requested a review May 2, 2022 12:46
@LuqueDaniel LuqueDaniel added enhancement Small improvements topic:syntax labels May 2, 2022
Copy link
Member

@LuqueDaniel LuqueDaniel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🎉

Thanks!

@LuqueDaniel LuqueDaniel merged commit 4dd2fcb into renpy:new-syntax May 2, 2022
@LuqueDaniel LuqueDaniel added this to the 2.1.0 milestone May 2, 2022
@duckdoom4 duckdoom4 deleted the pr branch May 2, 2022 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Small improvements topic:syntax
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants