-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add MigrationGenerator to create moirai_translations table #4
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love it!
README.md
Outdated
$ rails generator moirai:install | ||
``` | ||
|
||
Migrate the create the table in your database: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Strange sentence
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
correct
README.md
Outdated
@@ -33,7 +33,17 @@ Mount the engine in your `config/routes.rb`: | |||
mount Moirai::Engine => '/moirai', as: 'moirai' | |||
``` | |||
|
|||
and run `bin/rails db:migrate`. | |||
Generate the necessary files including the database migration: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we also mount the engine automatically? Not for this PR. I'll add it to the questions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oooo that would be fancy! let's look in to this
Co-authored-by: Daniel Bengl <53896675+CuddlyBunion341@users.noreply.github.com>
No description provided.