Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add MigrationGenerator to create moirai_translations table #4

Merged
merged 3 commits into from
Oct 22, 2024

Conversation

oliveranthony17
Copy link
Contributor

No description provided.

Copy link
Member

@coorasse coorasse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it!

README.md Outdated
$ rails generator moirai:install
```

Migrate the create the table in your database:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strange sentence

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

correct

README.md Outdated
@@ -33,7 +33,17 @@ Mount the engine in your `config/routes.rb`:
mount Moirai::Engine => '/moirai', as: 'moirai'
```

and run `bin/rails db:migrate`.
Generate the necessary files including the database migration:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we also mount the engine automatically? Not for this PR. I'll add it to the questions

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oooo that would be fancy! let's look in to this

oliveranthony17 and others added 2 commits October 22, 2024 11:45
Co-authored-by: Daniel Bengl <53896675+CuddlyBunion341@users.noreply.github.com>
@oliveranthony17 oliveranthony17 merged commit 2e6f8fe into main Oct 22, 2024
20 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants