Add support for strings in gems #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coorasse
force-pushed
the
support_non_existing_translations
branch
from
f139220
to
bfa8ff9
Compare
CuddlyBunion341
approved these changes
Nov 4, 2024
| @@ -1,3 +1,8 @@ | |||
| ## Unreleased | |||
There was a problem hiding this comment.
Great idea to include unreleased changes in the CHANGELOG 👍🏻
| else | ||
| redirect_back_or_to moirai_translation_files_path, status: :unprocessable_entity | ||
| end | ||
| redirect_back_or_to moirai_translation_files_path, status: :unprocessable_entity |
There was a problem hiding this comment.
I like this simplification
| locale ||= I18n.locale | ||
| moirai_translations[locale.to_sym][key] | ||
| moirai_translations[locale.to_sym].select do |_filename, data| |
There was a problem hiding this comment.
Why not filter_map?
Suggested change
| moirai_translations[locale.to_sym].select do |_filename, data| | |
| moirai_translations[locale.to_sym].filter_map { |filename, data| filename if data.dig(*key.split(".")).present? } | |
| .sort_by { |file_path| file_path.start_with?(Rails.root.to_s) ? 0 : 1 } |
| @@ -15,12 +15,25 @@ def call | |||
| changes | |||
| end | |||
|
|
|||
| def best_file_path_for(key, locale) | |||
|
|
||
| visit "/?locale=de&moirai=true" | ||
| refute_key_editable page, "buttons.very.much.nested.only_english" | ||
| refute_key_editable page, "buttons.very.much.nested.only_italian" | ||
| assert_key_editable page, "buttons.very.much.nested.only_english" |
There was a problem hiding this comment.
Very nice assertion helpers!
| @@ -3,6 +3,7 @@ | |||
| Moirai::Engine.routes.draw do | |||
| root to: "translation_files#index" | |||
|
|
|||
| resources :translations, only: %i[index] | |||
There was a problem hiding this comment.
I like the addition of the translations controller, but I lack a link to it for example from the /moirai page. Would this be something to take into consideration or should we just keep it for debugging purposes?
There was a problem hiding this comment.
At the moment is very ugly. We could for sure link it, but is also not documented at the moment, so let's keep it for debugging purpose for now.
Co-authored-by: Daniel Bengl <53896675+CuddlyBunion341@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for both strings coming from gems and strings not yet translated in the current language.
It enables to widen much more the range of strings that is possible to translate with moirai.
Replaces #32