Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: controller tests improvements [1] #2032

Merged
merged 12 commits into from
Mar 27, 2024
Merged

chore: controller tests improvements [1] #2032

merged 12 commits into from
Mar 27, 2024

Conversation

tomiir
Copy link
Collaborator

@tomiir tomiir commented Mar 6, 2024

Breaking Changes

N/A

Changes

  • feat:
  • fix:
  • chore: tests and improvements for AcccountController, ApiController, AssetController, ConnectionController and ConnectorController

Copy link

vercel bot commented Mar 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
web3modal-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 27, 2024 1:54pm
web3modal-gallery ✅ Ready (Inspect) Visit Preview Mar 27, 2024 1:54pm
web3modal-laboratory ✅ Ready (Inspect) Visit Preview Mar 27, 2024 1:54pm
web3modal-react-wagmi-ex ✅ Ready (Inspect) Visit Preview Mar 27, 2024 1:54pm
web3modal-vue-wagmi-ex ✅ Ready (Inspect) Visit Preview Mar 27, 2024 1:54pm

svenvoskamp
svenvoskamp previously approved these changes Mar 26, 2024
Copy link
Contributor

@svenvoskamp svenvoskamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ⚡️

svenvoskamp
svenvoskamp previously approved these changes Mar 27, 2024
Copy link
Contributor

@svenvoskamp svenvoskamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved if ci is green

@tomiir tomiir merged commit dc64fe2 into V4 Mar 27, 2024
15 checks passed
@tomiir tomiir deleted the chore/controller-tests branch March 27, 2024 13:58
@tomiir tomiir mentioned this pull request Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants