Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

:fix mobile switch network on mobile mm #3328

Merged
merged 8 commits into from
Nov 27, 2024
Merged

Conversation

svenvoskamp
Copy link
Contributor

@svenvoskamp svenvoskamp commented Nov 25, 2024

Description

MM mobile wallet only returns 1 namespace on the UniversalProvider session. This makes it impossible to switch chain if you're connected with MM. Setting supportsAllNetworks will make the networks able to be switched to.

Type of change

  • Chore (non-breaking change that addresses non-functional tasks, maintenance, or code quality improvements)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Associated Issues

For Linear issues: Closes APKT-1526

Showcase (Optional)

If there is a UI change include the screenshots with before and after state.
If new feature is being introduced, include the link to demo recording.

Checklist

  • Code in this PR is covered by automated tests (Unit tests, E2E tests)
  • My changes generate no new warnings
  • I have reviewed my own code
  • I have filled out all required sections
  • I have tested my changes on the preview link
  • Approver of this PR confirms that the changes are tested on the preview link

Copy link

changeset-bot bot commented Nov 25, 2024

🦋 Changeset detected

Latest commit: 0ca19a3

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Nov 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
appkit-gallery-new ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 27, 2024 9:19am
appkit-laboratory ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 27, 2024 9:19am
appkit-laboratory-new ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 27, 2024 9:19am
appkit-vue-solana ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 27, 2024 9:19am
appkit-wagmi-cdn-example ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 27, 2024 9:19am
vue-wagmi-example ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 27, 2024 9:19am

Copy link
Contributor

github-actions bot commented Nov 25, 2024

Coverage Report for Coverage

Status Category Percentage Covered / Total
🔵 Lines 400.72999999999996% 5319 / 24147
🔵 Statements 400.72999999999996% 5319 / 24147
🔵 Functions 413.33% 408 / 1477
🔵 Branches 559.6400000000001% 802 / 1792
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/appkit/src/client.ts 50.56% 72.67% 71.31% 50.56% 190-191, 234-235, 238-239, 254-257, 260-263, 266-267, 296-307, 310-319, 415, 419, 426, 464-467, 473-480, 483, 571-583, 602-605, 612-613, 621-622, 637-638, 641-642, 645-646, 649-650, 659-669, 675-682, 699-702, 711-740, 742-779, 781-785, 807-812, 814-822, 824-833, 835-855, 857-864, 866-877, 879-892, 894-897, 899-902, 904-907, 909-912, 914-921, 926-987, 990-1009, 1017-1018, 1026-1027, 1031-1129, 1132-1144, 1150-1153, 1157-1187, 1197, 1203-1218, 1222-1224, 1228-1243, 1248-1258, 1261-1339, 1342-1356, 1383, 1400, 1429-1435, 1437-1448, 1450-1457, 1479-1495, 1510-1514, 1529, 1543, 1545-1546, 1584, 1586-1587, 1593-1604, 1611-1612, 1622, 1624, 1705, 1722-1726
Generated in workflow #7628 for commit 0ca19a3 by the Vitest Coverage Report Action

Copy link

linear bot commented Nov 26, 2024

@svenvoskamp svenvoskamp merged commit f270e13 into main Nov 27, 2024
20 checks passed
@svenvoskamp svenvoskamp deleted the fix/mobile-switch-network branch November 27, 2024 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants