-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: send statusChange event to sync wagmi status with account controller #3329
Merged
enesozturk
merged 25 commits into
main
from
refactor/wagmi-status-sync-with-account-controller
Nov 26, 2024
Merged
refactor: send statusChange event to sync wagmi status with account controller #3329
enesozturk
merged 25 commits into
main
from
refactor/wagmi-status-sync-with-account-controller
Nov 26, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 575190f The changes in this PR will be included in the next version bump. This PR includes changesets to release 16 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
tomiir
approved these changes
Nov 26, 2024
enesozturk
deleted the
refactor/wagmi-status-sync-with-account-controller
branch
November 26, 2024 12:22
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We are exposing
status
value fromuseAppKitAccount
hook and this status value is not working stable across different adapters.We've tried using the
watchAccount
from Wagmi to keep our state sync with Wagmi's internal state. This has several problems;watchAccount
from Wagmi, since the other adapters don't have such listener, we should eventually update status manually depending on the connection status.Current problem with this PR's approach:
Type of change
Associated Issues
For Linear issues: Closes APKT-xxx
For GH issues: closes #...
Showcase (Optional)
If there is a UI change include the screenshots with before and after state.
If new feature is being introduced, include the link to demo recording.
Checklist