Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add check for missing address or chainId when getting siwe session #3332

Merged
merged 12 commits into from
Nov 27, 2024

Conversation

zoruka
Copy link
Contributor

@zoruka zoruka commented Nov 25, 2024

Description

Adds check for missing address or chainId when getting siwe session for guarantee of backwards compatibility.

Type of change

  • Chore (non-breaking change that addresses non-functional tasks, maintenance, or code quality improvements)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Associated Issues

For Linear issues: Closes APKT-xxx
For GH issues: closes #...

Showcase (Optional)

If there is a UI change include the screenshots with before and after state.
If new feature is being introduced, include the link to demo recording.

Checklist

  • Code in this PR is covered by automated tests (Unit tests, E2E tests)
  • My changes generate no new warnings
  • I have reviewed my own code
  • I have filled out all required sections
  • I have tested my changes on the preview link
  • Approver of this PR confirms that the changes are tested on the preview link

Copy link

changeset-bot bot commented Nov 25, 2024

🦋 Changeset detected

Latest commit: 463f411

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Nov 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
appkit-gallery-new ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 27, 2024 1:39pm
appkit-laboratory ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 27, 2024 1:39pm
appkit-laboratory-new ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 27, 2024 1:39pm
appkit-vue-solana ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 27, 2024 1:39pm
appkit-wagmi-cdn-example ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 27, 2024 1:39pm
vue-wagmi-example ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 27, 2024 1:39pm

Copy link
Contributor

github-actions bot commented Nov 25, 2024

Coverage Report for Coverage

Status Category Percentage Covered / Total
🔵 Lines 401.36999999999995% 5332 / 24167
🔵 Statements 401.36999999999995% 5332 / 24167
🔵 Functions 413.33% 408 / 1477
🔵 Branches 560.7200000000001% 812 / 1804
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/core/src/controllers/ChainController.ts 70.61% 67.27% 66.66% 70.61% 71-74, 77-81, 84-101, 106-107, 144-145, 187-197, 202-203, 210, 228-229, 233-241, 244-259, 262-265, 273-274, 277-278, 287-288, 293-294, 310-311, 316-317, 329-330, 363-371, 374-375, 378-379, 410-417, 429-430, 449-452, 475-476
packages/core/src/utils/SIWXUtil.ts 5.21% 100% 0% 5.21% 17-18, 20-57, 59-135, 137-149, 151-160, 162-174, 176-264, 266-272
packages/siwe/src/mapToSIWX.ts 94.64% 90.38% 100% 94.64% 19-20, 90-91, 155-156, 210-213
Generated in workflow #7644 for commit 463f411 by the Vitest Coverage Report Action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants