Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

:feat listen to transactions for every adapter. #3382

Merged
merged 24 commits into from
Dec 6, 2024

Conversation

svenvoskamp
Copy link
Contributor

@svenvoskamp svenvoskamp commented Dec 3, 2024

Description

Currently when a transaction has been made in AppKit, the balance won't update. This is a blocker for several clients. With this PR we are listening to transactionEvents and fetch the balance on these events.

wagmi: for wagmi we are using https://wagmi.sh/core/api/actions/watchPendingTransactions
ethers: for ethers we are using the pending event
solana: For Solana we need to emit the event in the provider itself

Type of change

  • Chore (non-breaking change that addresses non-functional tasks, maintenance, or code quality improvements)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Associated Issues

For Linear issues: Closes APKT-820
For GH issues: closes #...

Showcase (Optional)

If there is a UI change include the screenshots with before and after state.
If new feature is being introduced, include the link to demo recording.

Checklist

  • Code in this PR is covered by automated tests (Unit tests, E2E tests)
  • My changes generate no new warnings
  • I have reviewed my own code
  • I have filled out all required sections
  • I have tested my changes on the preview link
  • Approver of this PR confirms that the changes are tested on the preview link

Copy link

changeset-bot bot commented Dec 3, 2024

🦋 Changeset detected

Latest commit: eb3abe5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 16 packages
Name Type
@reown/appkit Patch
@reown/appkit-adapter-ethers Patch
@reown/appkit-adapter-ethers5 Patch
@reown/appkit-adapter-solana Patch
@reown/appkit-adapter-wagmi Patch
@reown/appkit-utils Patch
@reown/appkit-cdn Patch
@reown/appkit-common Patch
@reown/appkit-core Patch
@reown/appkit-experimental Patch
@reown/appkit-polyfills Patch
@reown/appkit-scaffold-ui Patch
@reown/appkit-siwe Patch
@reown/appkit-siwx Patch
@reown/appkit-ui Patch
@reown/appkit-wallet Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Dec 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
appkit-laboratory ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 6, 2024 8:38am
appkit-vue-solana ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 6, 2024 8:38am
appkit-wagmi-cdn-example ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 6, 2024 8:38am
vue-wagmi-example ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 6, 2024 8:38am

Copy link
Contributor

github-actions bot commented Dec 3, 2024

Coverage Report for Coverage

Status Category Percentage Covered / Total
🔵 Lines 402.92999999999995% 5430 / 24431
🔵 Statements 402.92999999999995% 5430 / 24431
🔵 Functions 417.83000000000004% 415 / 1487
🔵 Branches 561.4700000000001% 832 / 1828
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/appkit/src/client.ts 51.19% 73.03% 72.58% 51.19% 190-191, 234-235, 238-239, 254-257, 260-263, 296-307, 310-319, 415, 419, 426, 464-467, 473-480, 483, 571-583, 602-605, 612-613, 621-622, 637-638, 641-642, 645-646, 649-650, 659-669, 675-682, 722-725, 734-763, 765-813, 815-819, 841-846, 848-856, 858-867, 869-889, 891-898, 900-911, 913-926, 928-931, 933-936, 938-941, 943-946, 948-955, 960-1021, 1024-1043, 1051-1052, 1060-1061, 1065-1171, 1174-1186, 1192-1195, 1199-1213, 1223, 1229-1244, 1248-1250, 1254-1256, 1260-1275, 1280-1289, 1292-1302, 1305-1383, 1386-1406, 1433, 1450, 1479-1485, 1487-1498, 1500-1507, 1521-1522, 1532-1548, 1563-1567, 1582, 1596, 1598-1599, 1644, 1646-1647, 1653-1664, 1671-1672, 1682, 1684, 1765, 1782-1786
packages/appkit/src/adapters/ChainAdapterBlueprint.ts 22.34% 66.66% 18.18% 22.34% 58-59, 67-70, 85-86, 93-102, 109-118, 125-157, 160-161, 170-175, 184-188, 197-201
packages/appkit-utils/src/solana/SolanaTypesUtil.ts 100% 100% 100% 100%
Generated in workflow #7788 for commit 1efcff5 by the Vitest Coverage Report Action

Copy link

linear bot commented Dec 3, 2024

@svenvoskamp svenvoskamp requested review from tomiir, zoruka, enesozturk and magiziz and removed request for enesozturk December 3, 2024 16:36
packages/adapters/ethers/src/client.ts Outdated Show resolved Hide resolved
packages/appkit/src/client.ts Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants