-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
:feat listen to transactions for every adapter. #3382
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: eb3abe5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 16 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
…om/appkit into feat/listen-pending-transactions
svenvoskamp
requested review from
tomiir,
zoruka,
enesozturk and
magiziz
and removed request for
enesozturk
December 3, 2024 16:36
magiziz
reviewed
Dec 3, 2024
…om/appkit into feat/listen-pending-transactions
…ending-transactions
magiziz
approved these changes
Dec 5, 2024
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently when a transaction has been made in AppKit, the balance won't update. This is a blocker for several clients. With this PR we are listening to transactionEvents and fetch the balance on these events.
wagmi: for wagmi we are using https://wagmi.sh/core/api/actions/watchPendingTransactions
ethers: for ethers we are using the
pending
eventsolana: For Solana we need to emit the event in the provider itself
Type of change
Associated Issues
For Linear issues: Closes APKT-820
For GH issues: closes #...
Showcase (Optional)
If there is a UI change include the screenshots with before and after state.
If new feature is being introduced, include the link to demo recording.
Checklist