Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(readme): remove misleading install size #3394

Merged
merged 3 commits into from
Dec 10, 2024
Merged

Conversation

arein
Copy link
Contributor

@arein arein commented Dec 5, 2024

The install size is not relevant to developers but bundle size is. Hence, removing install size.

Description

Please include a brief summary of the change.

Type of change

  • Chore (non-breaking change that addresses non-functional tasks, maintenance, or code quality improvements)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Associated Issues

For Linear issues: Closes APKT-xxx
For GH issues: closes #...

Showcase (Optional)

If there is a UI change include the screenshots with before and after state.
If new feature is being introduced, include the link to demo recording.

Checklist

  • Code in this PR is covered by automated tests (Unit tests, E2E tests)
  • My changes generate no new warnings
  • I have reviewed my own code
  • I have filled out all required sections
  • I have tested my changes on the preview link
  • Approver of this PR confirms that the changes are tested on the preview link

The install size is not relevant to developers but bundle size is. Hence, removing install size.
@arein arein requested review from tomiir and lukaisailovic December 5, 2024 05:00
Copy link

vercel bot commented Dec 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
appkit-builder ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 10, 2024 3:11pm
appkit-laboratory ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 10, 2024 3:11pm
appkit-vue-solana ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 10, 2024 3:11pm
appkit-wagmi-cdn-example ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 10, 2024 3:11pm
vue-wagmi-example ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 10, 2024 3:11pm

Copy link

changeset-bot bot commented Dec 5, 2024

⚠️ No Changeset found

Latest commit: 45af6df

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Dec 5, 2024

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 51.47% 13543 / 26308
🔵 Statements 51.47% 13543 / 26308
🔵 Functions 38.7% 966 / 2496
🔵 Branches 74.61% 1602 / 2147
File CoverageNo changed files found.
Generated in workflow #7997 for commit 45af6df by the Vitest Coverage Report Action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants