Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: iframe deeplink #3403

Merged
merged 5 commits into from
Dec 6, 2024
Merged

fix: iframe deeplink #3403

merged 5 commits into from
Dec 6, 2024

Conversation

lukaisailovic
Copy link
Collaborator

@lukaisailovic lukaisailovic commented Dec 6, 2024

Description

Fixing iframe deeplink resolution. Currently if AppKit is in an iframe deeplinks still try to open on the _self target, and won't do anything. This will open them on _top target.

Type of change

  • Chore (non-breaking change that addresses non-functional tasks, maintenance, or code quality improvements)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Associated Issues

For Linear issues: Closes APKT-xxx
For GH issues: closes #...

Showcase (Optional)

If there is a UI change include the screenshots with before and after state.
If new feature is being introduced, include the link to demo recording.

Checklist

  • Code in this PR is covered by automated tests (Unit tests, E2E tests)
  • My changes generate no new warnings
  • I have reviewed my own code
  • I have filled out all required sections
  • I have tested my changes on the preview link
  • Approver of this PR confirms that the changes are tested on the preview link

Copy link

vercel bot commented Dec 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
appkit-laboratory ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 6, 2024 0:06am
appkit-vue-solana ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 6, 2024 0:06am
appkit-wagmi-cdn-example ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 6, 2024 0:06am
vue-wagmi-example ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 6, 2024 0:06am

Copy link

changeset-bot bot commented Dec 6, 2024

🦋 Changeset detected

Latest commit: a107812

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 16 packages
Name Type
@reown/appkit-scaffold-ui Patch
@reown/appkit-core Patch
@reown/appkit-adapter-ethers Patch
@reown/appkit-adapter-ethers5 Patch
@reown/appkit-adapter-solana Patch
@reown/appkit-adapter-wagmi Patch
@reown/appkit Patch
@reown/appkit-utils Patch
@reown/appkit-cdn Patch
@reown/appkit-common Patch
@reown/appkit-experimental Patch
@reown/appkit-polyfills Patch
@reown/appkit-siwe Patch
@reown/appkit-siwx Patch
@reown/appkit-ui Patch
@reown/appkit-wallet Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Dec 6, 2024

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 47.78% 12341 / 25826
🔵 Statements 47.78% 12341 / 25826
🔵 Functions 34.4% 838 / 2436
🔵 Branches 76.62% 1318 / 1720
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/core/src/utils/CoreHelperUtil.ts 48.12% 83.33% 36.61% 48.12% 12-19, 23, 27-29, 33-35, 39, 43, 47, 51, 58-59, 67, 82-93, 97, 101-122, 126-138, 142-146, 149, 153-157, 164-168, 173-181, 201-216, 232-241, 249-254, 273, 275, 277-278, 288-293, 297-300, 310, 315, 320, 330-331, 339-348, 351-360, 112-169
packages/scaffold-ui/src/partials/w3m-connecting-wc-mobile/index.ts 14.28% 100% 0% 14.28% 16-37, 40-44, 48-52, 55-80, 83-90, 75
Generated in workflow #7913 for commit a107812 by the Vitest Coverage Report Action

@lukaisailovic lukaisailovic merged commit d4352b0 into main Dec 6, 2024
18 checks passed
@lukaisailovic lukaisailovic deleted the fix/iframe-deeplinks branch December 6, 2024 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants