Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: appkit demo #3413

Merged
merged 82 commits into from
Dec 10, 2024
Merged

feat: appkit demo #3413

merged 82 commits into from
Dec 10, 2024

Conversation

enesozturk
Copy link
Contributor

@enesozturk enesozturk commented Dec 9, 2024

Description

Introducing AppKit demo application. This PR includes changes to have the initial changes for Demo (aka previously Builder) application.

Main features:

  • Customize connection methods
  • Customize wallet features
  • Customize theme
  • Share customization via URL

All the required changes to AppKit has been handled separate PRs. See:

Type of change

  • Chore (non-breaking change that addresses non-functional tasks, maintenance, or code quality improvements)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Associated Issues

For Linear issues: Closes APKT-1424, APKT-1426, APKT-650, APKT-649, APKT-646, APKT-1466, APKT-1465, APKT-775, APKT-1585, APKT-1584, APKT-1681

Showcase (Optional)

appkit-demo.mp4

Checklist

  • Code in this PR is covered by automated tests (Unit tests, E2E tests)
  • My changes generate no new warnings
  • I have reviewed my own code
  • I have filled out all required sections
  • I have tested my changes on the preview link
  • Approver of this PR confirms that the changes are tested on the preview link

Copy link
Contributor

github-actions bot commented Dec 9, 2024

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 50.79% 13363 / 26308
🔵 Statements 50.79% 13363 / 26308
🔵 Functions 37.74% 942 / 2496
🔵 Branches 75.06% 1553 / 2069
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/scaffold-ui/src/modal/w3m-modal/index.ts 40.41% 55.55% 31.25% 40.41% 60-61, 65-67, 82-89, 109-112, 115-121, 130-135, 138-142, 145-158, 161-165, 168-185, 188-190, 193-202, 205-224
packages/scaffold-ui/src/partials/w3m-account-wallet-features-widget/index.ts 59.5% 57.89% 57.89% 59.5% 54-62, 72-74, 112, 117, 127-128, 142, 145, 152-153, 163, 174-183, 190-191, 202, 213-221, 230-231, 233-234, 236-237, 244-248, 254-255, 258-259, 262-263, 266-286, 289-290, 293-304, 282-301
Generated in workflow #7974 for commit a65b45e by the Vitest Coverage Report Action

Copy link

linear bot commented Dec 9, 2024

@enesozturk enesozturk requested a review from zoruka December 9, 2024 16:16
apps/builder/app/page.tsx Outdated Show resolved Hide resolved
const titleValueMap = {
Buy: 'onramp',
Swap: 'swaps',
Receive: 'receive',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does Receive feature changes anything in the Modal? I could not see differences in the preview

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's only visible on the embedded wallet connection. The default (old) account view doesn't have this as one of the options in the list

Copy link
Contributor

@zoruka zoruka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The preview is looking really good 🚀

Copy link
Contributor

@svenvoskamp svenvoskamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work ✨

Left 1 small comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants