refactor: make the wallet image listen state updates for embedded use case #3466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 23526a9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 18 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
enesozturk
changed the title
enesozturk
changed the title
enesozturk
requested review from
tomiir and
svenvoskamp
and removed request for
tomiir
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||||||||
magiziz
approved these changes
Dec 16, 2024
tomiir
reviewed
Dec 16, 2024
| public constructor() { | ||
| super() | ||
| this.unsubscribe.push( | ||
| ConnectorController.subscribeKey('connectors', val => (this.connectors = val)) | ||
| ConnectorController.subscribeKey('connectors', val => (this.connectors = val)), | ||
| AssetController.subscribeKey('connectorImages', val => (this.connectorImages = val)) |
There was a problem hiding this comment.
just confirming these are automatically fetched during initialization
tomiir
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
connectorImagesobject state update instead to trigger Valtio life cyclew3m-list-walletelement to watchconnectorImageschanges to render some connector images properly for embedded mode use caseType of change
Associated Issues
For Linear issues: Closes APKT-xxx
For GH issues: closes #...
Showcase (Optional)
If there is a UI change include the screenshots with before and after state.
If new feature is being introduced, include the link to demo recording.
Checklist