Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix infinite pendingTransactions event and add pendingTransactionFilter option #3514

Merged
merged 12 commits into from
Dec 19, 2024

Conversation

magiziz
Copy link
Contributor

@magiziz magiziz commented Dec 19, 2024

Description

Wagmi currently has an issue where it keeps spamming pendingTransactions event. For now we've disabled it and added a new option called pendingTransactionFilter if users want to enable realtime balance updates.

Type of change

  • Chore (non-breaking change that addresses non-functional tasks, maintenance, or code quality improvements)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Associated Issues

For Linear issues: Closes APKT-1816

Checklist

  • Code in this PR is covered by automated tests (Unit tests, E2E tests)
  • My changes generate no new warnings
  • I have reviewed my own code
  • I have filled out all required sections
  • I have tested my changes on the preview link
  • Approver of this PR confirms that the changes are tested on the preview link

Copy link

changeset-bot bot commented Dec 19, 2024

🦋 Changeset detected

Latest commit: 46dd2b5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 19 packages
Name Type
@reown/appkit-adapter-wagmi Patch
@reown/appkit Patch
@reown/appkit-common Patch
@reown/appkit-adapter-bitcoin Patch
@reown/appkit-adapter-ethers Patch
@reown/appkit-adapter-ethers5 Patch
@reown/appkit-adapter-solana Patch
@reown/appkit-utils Patch
@reown/appkit-cdn Patch
@reown/appkit-cli Patch
@reown/appkit-core Patch
@reown/appkit-experimental Patch
@reown/appkit-polyfills Patch
@reown/appkit-scaffold-ui Patch
@reown/appkit-siwe Patch
@reown/appkit-siwx Patch
@reown/appkit-ui Patch
@reown/appkit-wallet Patch
@reown/appkit-wallet-button Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Dec 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
appkit-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 19, 2024 8:22pm
appkit-laboratory ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 19, 2024 8:22pm
appkit-vue-solana ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 19, 2024 8:22pm
appkit-wagmi-cdn-example ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 19, 2024 8:22pm
vue-wagmi-example ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 19, 2024 8:22pm

Copy link
Collaborator

@tomiir tomiir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a test plz 🙏

Copy link
Contributor

github-actions bot commented Dec 19, 2024

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 58.1% 16109 / 27722
🔵 Statements 58.1% 16109 / 27722
🔵 Functions 46.08% 1220 / 2647
🔵 Branches 75.68% 2247 / 2969
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/adapters/wagmi/src/client.ts 74.68% 54.76% 75.75% 74.68% 122-148, 173, 192-193, 218-219, 231-235, 241-244, 275, 277, 306-307, 358-361, 366-367, 377-378, 417-418, 429, 449, 454-469, 472-491, 501-502, 506-507, 524-535, 574, 578-579, 600-601, 609-610, 615-616, 620-625, 632-633, 641-642, 647-648, 657-658, 666-667, 672-673
packages/adapters/wagmi/src/utils/LimitterUtil.ts 100% 100% 100% 100%
packages/appkit/exports/constants.ts 100% 100% 100% 100%
packages/common/src/utils/ConstantsUtil.ts 100% 100% 100% 100%
Generated in workflow #8304 for commit 46dd2b5 by the Vitest Coverage Report Action

@magiziz magiziz changed the title chore: set limit for pending transaction event chore: fix infinite pendingTransactions event and add pendingTransactionFilter option Dec 19, 2024
Copy link

linear bot commented Dec 19, 2024

@tomiir tomiir merged commit 15bfe49 into main Dec 19, 2024
19 checks passed
@tomiir tomiir deleted the chore/cap-limit-on-pending-transactions branch December 19, 2024 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants