Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update implementation.mdx #231

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

satyam-mishra-pce
Copy link

Update the implementation to use providers for better code clarity.

Description

I was going through the docs to use it with ethers library... But, the implementation code was pretty unclear about whether to use Provider here or not. The earlier code, just used the createAppKit function, and that's it, but it as I infered from other examples (wagmi, for instance), this value returned by the function needed to be stored as appkit, in the context. In the next code block, AppKit was clearly being imported the way a Provider is done, therefore it made sense to update the code to be more clear about using a ContextProvider here.

I went on to create a provider, and tried using it on my end, and it worked.

Tests

I am a beginner, so I couldn't do the following tests as suggested by maintainers:

  • - Ran the changes locally with Docusaurus. and confirmed that the changes appear as expected.
  • - Applied the corrections suggested by Cspell on the .mdx files with changes.

Update the implementation to use providers for better code clarity.
Copy link

vercel bot commented Jan 5, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
reown-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 5, 2025 9:11am

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant