Load conf/log4j.properties automatically if exists
#203
Conversation
In Play! 1.5.x documentation [1] the property "application.log.path" description is the following: Path to a Log4J configuration file, to customise log output. If you do not specify a path, Play will load a log4j.properties file in the conf directory if present. The same can be found in the annotated application.conf: "If you want a very customized log, create a log4j.properties file in the conf directory" I'm unsure if it worked at all in Play!, but it's a nice feature. The init_with_conf_dir() test tries to check the parameters of the newly added "conf/log4j.properties". The init_with_default_config() test deletes that properties file from the test classpath and checks for the Framework's properties file. [1]: https://www.playframework.com/documentation/1.5.x/configuration#application.log.path
In Play! 1.5.x documentation [1] the property "application.log.path" description is the following: Path to a Log4J configuration file, to customise log output. If you do not specify a path, Play will load a log4j.properties file in the conf directory if present. The same can be found in the annotated application.conf: "If you want a very customized log, create a log4j.properties file in the conf directory" I'm unsure if it worked at all in Play!, but it's a nice feature. [1]: https://www.playframework.com/documentation/1.5.x/configuration#application.log.path
|
@xabolcs Wait, but... I thought RePlay adds "conf" directory to classpath anyway. |
|
Well, that's why I added the failing test. 🙂 ... And strictly speaking: RePlay doesn't add the This PR improves the situation for those who copy the |
|
@xabolcs Ah so. Thanks, it explains why you need it. Yes, I think in our working projects we added |
Hi @asolntsev ,
this is another low hanging fruit: let the Framework load the
log4j.propertiesfromconfdirectory if exists.I also added a failing test before implementing the improvement.