Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Architectural cleanup #7026

Merged
merged 3 commits into from
Jun 1, 2022
Merged

Conversation

bvaughn
Copy link
Contributor

@bvaughn bvaughn commented Jun 1, 2022

Relates to architectural proposal #6932; small follow up to #6992.

Had a couple of small follow up ideas last night while I was trying to sleep:

  • Add unit tests for the Suspense utility and add a small performance optimization to the time-to-points fetching so that we now suspend in parallel for begin and end points.
  • Separate the contexts and their React hooks integration into separate files with their own React component. This pattern simplifies usage of the contexts (as we add more) and provides greater flexibility when testing.

@vercel
Copy link

vercel bot commented Jun 1, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
devtools ✅ Ready (Inspect) Visit Preview Jun 1, 2022 at 0:21AM (UTC)

@bvaughn bvaughn merged commit d901d3c into main Jun 1, 2022
@bvaughn bvaughn deleted the bvaughn-architecture-proof-of-concept-pt2 branch June 1, 2022 12:35
@bvaughn bvaughn restored the bvaughn-architecture-proof-of-concept-pt2 branch June 1, 2022 14:11
@jcmorrow jcmorrow deleted the bvaughn-architecture-proof-of-concept-pt2 branch June 8, 2022 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants