New Object Inspector UI (architecture investigation) #7235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
![replay-soc2[bot]](https://avatars.githubusercontent.com/u/60818315?s=60&v=4){kind=small}
![semgrep-app[bot]](https://avatars.githubusercontent.com/in/60555?s=60&v=4){kind=small}
packages/bvaughn-architecture-demo/components/inspector/values/FunctionRenderer.tsx
Show resolved
Hide resolved
✅ QA Wolf - Deploy PR
✅ 8 passed |
|
Obviously there's a lot of code here :) Skimmed through it, and it seems pretty legible, well-structured, and well-commented. Really, my main question is: what's a feasible path to adding this to the existing codebase? |
bvaughn
commented
Jun 21, 2022
| export interface GetTestsRun_node_Workspace_testRuns_recordings_edges_node { | ||
| __typename: "Recording"; | ||
| uuid: any; | ||
| duration: number | null; | ||
| createdAt: any; | ||
| metadata: any | null; | ||
| comments: GetTestsRun_node_Workspace_testRuns_recordings_edges_node_comments[]; |
There was a problem hiding this comment.
Wish I knew why I had to update this file to make our CI type check happy. I didn't touch anything related to this.
|
Thanks Mark! After some discussion over VC, I'm going to go ahead and land this change set, and then iterate on it some more with a follow up PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new Object Inspector. Key concepts include:
Suspense.ValueFront.OffscreenAPI used to remember state (e.g. collapsed/expanded) in conditionally-rendered children.Loom walk through of the architecture:
https://www.loom.com/share/69b18fb36bfb4ab6b70a2bda49afa499
To test the new component:
cd packages/bvaughn-architecture-demo && npm run dev)FE-322