Allow the appsettings.json to be defined via env variable CONFIG_DIR #300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes the usage via docker/kubernetes much easier since we can split the code and the data making the last one persisted in a volume. Example: `CONFIG_DIR="/app/data"` - All code is inside `/app` - database and config is inside `/app/data` - a new volume is mounted for `/app/data` Thanks!
|
Thanks for this, containerizing has been on my todo list for a while. I'll take a look at this today |
|
No worries, I have a docker container (for arm64 but could be made for several archs) here: https://github.com/csobrinho/binner-docker/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the usage via docker/kubernetes much easier since we can split the code and the data making the last one persisted in a volume.
Example:
CONFIG_DIRto/app/data/app/app/data/app/dataDocker Image for ARM64: https://github.com/csobrinho/binner-docker
Kubernetes app: https://github.com/csobrinho/homelab/tree/main/apps/binner/overlays/prod
PS: My C# is rusty so please double-check both the syntax and codestyle fits, thanks!