-
Notifications
You must be signed in to change notification settings - Fork 222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error when succesfully deleting model without version #356
Comments
Hi @detkov. Thanks for reporting. I believe this is a problem with the API, so I'll work with the team to get this fixed. |
Following up — I just opened #359 to fix what we can on the client. I also filed a ticket internally to get the API to respond with something more helpful when a model isn't found ("No ModelRedirect matches the given query." is a red herring). |
mattt
added a commit
that referenced
this issue
Sep 25, 2024
Resolves #356 When deleting a model, Replicate's API returns with a 204 and an empty response body. The client library fails to decode this and raises and exception. This PR updates the `replicate.models.delete` method to return `bool` instead to indicate success. It also harmonizes the other delete methods for deployments and files to do the same. Signed-off-by: Mattt Zmuda <mattt@replicate.com>
This is now fixed in v0.34.1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I had a model
model
without a version (it was there, but I deleted it):I tried to delete it and got the following error:
However, when trying to get this model using, another error occurs, which means that the model was indeed deleted:
So it seems to me that the problem is somewhere in the
replicate.models.delete
response decoding.replicate==0.33.0
The text was updated successfully, but these errors were encountered: