Fix bug with wait parameter in replicate.run()
#363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue with
replicate.run()where it would fallback to polling irregardless of thewaitparameter. We now skip the waiting if it looks like we have a prediction with output back.There are a whole bunch of issues with the
vcrlibrary we're using at the moment. I've got it working but I don't think the fixtures are in an ideal state.vcrrecording mode doesn't work with asyncio, so you need to generate the fixtures using the sync api. Commenting out all of theasync&awaitsyntax. Then the test will run just fine without.vcr()decorator is not respected while recording. Apparently it does work if you rename the generated file, but I've not tried this yet.