-
Notifications
You must be signed in to change notification settings - Fork 222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add timings #75
Add timings #75
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice. I like this as an approach.
We should definitely get the timing info in, but I'm not sure about this new method, so maybe we shouldn't conflate the two changes. Is this new method just for convenience, or is there a technical reason why we need it? This is creating a new
That would also imply |
@bfirsh we don't explicitly need it; I suppose I appreciate the simplicity of having one Also a spot where the JS & python clients diverge at the moment, All that said, happy to just push the timings and leave the API as is if it doesn't feel right. |
Let's maybe pull that out into a separate PR for discussion. I don't want to block getting the uncontroversial change in. I think we should think carefully about adding a new naming pattern for an API, particularly as we're in the process of trying to align the Python and JS APIs. |
Signed-off-by: dan nelson <dan.nelson8@gmail.com>
@bfirsh works for me. This is now just timing info. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice
Wanted to add the ability in the python API to return the timing information (
created_at
,started_at
,completed_at
) so that we can pull all that info right in python without hopping back and forth between curl/etc.Didn't want to break the existing
predict() -> prediction.output
contract, which led me to implementing acreate_prediction
method that returns an async prediction object (similar, I think, to the current JS API).