Skip to content

Commit

Permalink
change openebs localpv storageclass name to 'local' from 'default'
Browse files Browse the repository at this point in the history
also clarify docs on when openebs will be the default storageclass
  • Loading branch information
laverya committed Feb 22, 2023
1 parent 69846a1 commit b1da863
Show file tree
Hide file tree
Showing 6 changed files with 13 additions and 19 deletions.
4 changes: 2 additions & 2 deletions src/markdown-pages/add-ons/kotsadm.md
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ spec:
openebs:
version: latest
isLocalPVEnabled: true
localPVStorageClassName: default
localPVStorageClassName: local
minio:
version: latest
registry:
Expand All @@ -107,7 +107,7 @@ spec:
openebs:
version: latest
isLocalPVEnabled: true
localPVStorageClassName: default
localPVStorageClassName: local
registry:
version: latest
kotsadm:
Expand Down
16 changes: 5 additions & 11 deletions src/markdown-pages/add-ons/openebs.md
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ spec:
version: latest
namespace: openebs
isLocalPVEnabled: true
localPVStorageClassName: openebs
localPVStorageClassName: local
```
flags-table
Expand All @@ -34,17 +34,11 @@ Additionally, Local Volumes are typically preferred for workloads like Cassandra

### Storage Class

The OpenEBS Storage Class can be set as the default by setting the `openebs.localPVStorageClassName` property to `"default"` or when no other storage provisioner add-on is included in the spec.
The OpenEBS Storage Class will be set as the default if:

In this example, the Local PV provisioner would be used as the default provisioner for any Persistent Volume Claims that do not explicitly specify a `storageClassName`.

```yaml
spec:
openebs:
version: latest
isLocalPVEnabled: true
localPVStorageClassName: default
```
1. Rook is not included in the spec.
2. There is no existing default Storage Class in the cluster.
3. Longhorn is not included in the spec OR the `openebs.localPVStorageClassName` property is set to `"default"`.

### Limitations

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ spec:
  openebs:
    version: "3.3.x"
    isLocalPVEnabled: true
    localPVStorageClassName: "default"
    localPVStorageClassName: "local"
```
Conversely, [Rook](/docs/add-ons/rook) provides dynamic PV provisioning of distributed [Ceph](https://ceph.io/) storage.
Expand Down Expand Up @@ -62,7 +62,7 @@ spec:
  openebs:
    version: "3.3.x"
    isLocalPVEnabled: true
    localPVStorageClassName: "default"
    localPVStorageClassName: "local"
  minio:
    version: "2022-09-07T22-25-02Z"
```
Expand Down
2 changes: 1 addition & 1 deletion src/markdown-pages/install-with-kurl/migrating.md
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ spec:
openebs:
version: 3.3.0
isLocalPVEnabled: true
localPVStorageClassName: default
localPVStorageClassName: local
registry:
version: 2.8.1
kotsadm:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ spec:
openebs:
version: 3.3.x
isLocalPVEnabled: true
localPVStorageClassName: default
localPVStorageClassName: local
registry:
version: 2.8.x
velero:
Expand Down
4 changes: 2 additions & 2 deletions src/utils/__tests__/kurl-yaml.js
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ spec:
openebs:
version: 3.3.x
isLocalPVEnabled: true
localPVStorageClassName: default
localPVStorageClassName: local
`;
const expected = `apiVersion: cluster.kurl.sh/v1beta1
kind: Installer
Expand Down Expand Up @@ -62,7 +62,7 @@ spec:
openebs:
version: 3.3.x
isLocalPVEnabled: true
localPVStorageClassName: default
localPVStorageClassName: local
`;
const actual = injectYamlOpenebsComment(yaml);
expect(actual).to.equal(expected);
Expand Down

0 comments on commit b1da863

Please sign in to comment.