Skip to content
This repository has been archived by the owner on Mar 24, 2023. It is now read-only.

use laverya/yaml to allow marshalling yaml with unlimited line lengths #1020

Merged
merged 2 commits into from
Jul 10, 2019

Conversation

laverya
Copy link
Member

@laverya laverya commented Jul 10, 2019

What I Did

Switched our yaml render step to use laverya/yaml, and with that an unlimited line length.

How I Did it

How to verify it

Description for the Changelog

Strings in kustomized yaml will only wrap on literal newlines

Picture of a Ship (not required but encouraged)

USS Bennington (CV-20)

Copy link

@codeclimate codeclimate bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 11310 lines exceeds the maximum allowed for the inline comments feature.

@laverya
Copy link
Member Author

laverya commented Jul 10, 2019

The relevant PR go-yaml/yaml#455 has been open since April 23rd, so I think it's getting time to accept that it won't be merged anytime soon.

Copy link

@codeclimate codeclimate bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 11338 lines exceeds the maximum allowed for the inline comments feature.

Copy link

@codeclimate codeclimate bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 12339 lines exceeds the maximum allowed for the inline comments feature.

@laverya laverya force-pushed the use-laverya-ship-for-line-length branch from ded1c7b to 9d2dcb9 Compare July 10, 2019 21:17
Copy link

@codeclimate codeclimate bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 12335 lines exceeds the maximum allowed for the inline comments feature.

@laverya laverya merged commit d78d5f9 into replicatedhq:master Jul 10, 2019
@laverya laverya deleted the use-laverya-ship-for-line-length branch July 10, 2019 21:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants