This repository has been archived by the owner on Mar 24, 2023. It is now read-only.
Pact tests for ship #980
Merged
Pact tests for ship #980
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
| @@ -314,9 +314,9 @@ func (c *GraphQLClient) GetSlugRelease(selector *Selector) (*state.ShipRelease, | |||
| return &shipResponse.Data.ShipSlugRelease, nil | |||
| } | |||
|
|
|||
| func (c *GraphQLClient) getLicense(selector *Selector) (*license, error) { | |||
| func (c *GraphQLClient) GetLicense(selector *Selector) (*license, error) { | |||
There was a problem hiding this comment.
exported method GetLicense returns unexported type *replicatedapp.license, which can be annoying to use
laverya
approved these changes
Jun 20, 2019
|
At some point in the future we should probably add some 'this is expected to fail' tests, but that can wait |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I Did
Created pact tests for the following queries:
1- GetSlugRelease
2- GetLicense
How I Did it
1- created two test files,
get_slug_release_test.goandget_license_test.go.2- created the test
3- ran it
4- verified it
How to verify it
make pacts, and look at the output file inpactsdirectory.Description for the Changelog
Added contract tests for GraphQL API Queries
Picture of a Ship (not required but encouraged)