This repository has been archived by the owner on Mar 24, 2023. It is now read-only.
Honor the log-format parameter for debug logs #988
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I Did
Made debug logger honor the
log-format
command line parameter. This closes #886.How I Did it
Removed the hardcoded call to
NewJSONLogger
.How to verify it
Run ship, look at debug logs. Instead of this:
there should be this:
Description for the Changelog
Debug logger honors the
log-format
command line parameterPicture of a Ship (not required but encouraged)
___________|