This repository has been archived by the owner on Mar 24, 2023. It is now read-only.
include all release info for replicated.app upstreams in the content sha #995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update init_app, update, and base integration tests to use the new shas
divolgin
approved these changes
Jun 24, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update init_app, update, and base integration tests to use the new shas
What I Did
Sequence number, github contents and entitlement values (among other things) are now used to calculate whether a
replicated.appupstream has been updated, not just the yaml spec.How I Did it
Content sha is calculated from a jsonified version of the ship app struct. Before converting to json, the entitlements signature is cleared, as it is not constant and should not trigger an app update.
How to verify it
New content shas in the integration tests. No-op release promotions (same yaml + different semver, etc) will cause
ship watchto return.Description for the Changelog
ship watchnow takes into account proxied Github contents and the release sequence when using areplicated.appupstreamPicture of a Ship (not required but encouraged)